From 3efb7e695712c557bbdee10a16e95095a1770b88 Mon Sep 17 00:00:00 2001 From: Florian Bruhin Date: Mon, 24 Sep 2018 19:45:31 +0200 Subject: [PATCH] Auto-remove PDF.js downloads --- qutebrowser/browser/webengine/webenginedownloads.py | 5 +++-- qutebrowser/browser/webkit/webpage.py | 3 ++- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/qutebrowser/browser/webengine/webenginedownloads.py b/qutebrowser/browser/webengine/webenginedownloads.py index 3f47dd640..94caa887e 100644 --- a/qutebrowser/browser/webengine/webenginedownloads.py +++ b/qutebrowser/browser/webengine/webenginedownloads.py @@ -212,16 +212,17 @@ class DownloadManager(downloads.AbstractDownloadManager): def handle_download(self, qt_item): """Start a download coming from a QWebEngineProfile.""" suggested_filename = _get_suggested_filename(qt_item.path()) + use_pdfjs = pdfjs.should_use_pdfjs(qt_item.mimeType(), qt_item.url()) download = DownloadItem(qt_item) - self._init_item(download, auto_remove=False, + self._init_item(download, auto_remove=use_pdfjs, suggested_filename=suggested_filename) if self._mhtml_target is not None: download.set_target(self._mhtml_target) self._mhtml_target = None return - if pdfjs.should_use_pdfjs(qt_item.mimeType(), qt_item.url()): + if use_pdfjs: download.set_target(downloads.PDFJSDownloadTarget()) return diff --git a/qutebrowser/browser/webkit/webpage.py b/qutebrowser/browser/webkit/webpage.py index 63017ec45..ce985b466 100644 --- a/qutebrowser/browser/webkit/webpage.py +++ b/qutebrowser/browser/webkit/webpage.py @@ -270,7 +270,8 @@ class BrowserPage(QWebPage): self.display_content, reply, 'image/jpeg')) elif pdfjs.should_use_pdfjs(mimetype, reply.url()): download_manager.fetch(reply, - target=downloads.PDFJSDownloadTarget()) + target=downloads.PDFJSDownloadTarget(), + auto_remove=True) else: # Unknown mimetype, so download anyways. download_manager.fetch(reply,