From 3de2bfb277f0bd8e10d4b44d8dc035af94822019 Mon Sep 17 00:00:00 2001 From: Florian Bruhin Date: Mon, 13 Feb 2017 11:23:29 +0100 Subject: [PATCH] Handle renderer process not starting at all --- qutebrowser/browser/browsertab.py | 3 ++- qutebrowser/browser/webengine/webenginetab.py | 2 ++ qutebrowser/mainwindow/tabbedbrowser.py | 2 ++ 3 files changed, 6 insertions(+), 1 deletion(-) diff --git a/qutebrowser/browser/browsertab.py b/qutebrowser/browser/browsertab.py index 5f9100b75..700bf88f2 100644 --- a/qutebrowser/browser/browsertab.py +++ b/qutebrowser/browser/browsertab.py @@ -78,7 +78,8 @@ TerminationStatus = usertypes.enum('TerminationStatus', [ 'normal', 'abnormal', # non-zero exit status 'crashed', # e.g. segfault - 'killed' + 'killed', + 'unknown', ]) diff --git a/qutebrowser/browser/webengine/webenginetab.py b/qutebrowser/browser/webengine/webenginetab.py index bbc0050a8..c5394ae7d 100644 --- a/qutebrowser/browser/webengine/webenginetab.py +++ b/qutebrowser/browser/webengine/webenginetab.py @@ -693,6 +693,8 @@ class WebEngineTab(browsertab.AbstractTab): browsertab.TerminationStatus.crashed, QWebEnginePage.KilledTerminationStatus: browsertab.TerminationStatus.killed, + -1: + browsertab.TerminationStatus.unknown, } self.renderer_process_terminated.emit(status_map[status], exitcode) diff --git a/qutebrowser/mainwindow/tabbedbrowser.py b/qutebrowser/mainwindow/tabbedbrowser.py index 7302bc3fb..115ee6f75 100644 --- a/qutebrowser/mainwindow/tabbedbrowser.py +++ b/qutebrowser/mainwindow/tabbedbrowser.py @@ -677,6 +677,8 @@ class TabbedBrowser(tabwidget.TabWidget): message.error("Renderer process crashed") elif status == browsertab.TerminationStatus.killed: message.error("Renderer process was killed") + elif status == browsertab.TerminationStatus.unknown: + message.error("Renderer process did not start") else: raise ValueError("Invalid status {}".format(status))