rnhmjoj/qutebrowser
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Don't crash on Content-Disposition with wrong enc.

Browse Source 
When declaring UTF-8 but encoding RFC2231 ISO-8859-1, rfc2259 raises an
UnicodeDecodeError.

Test case: http://greenbytes.de/tech/tc2231/#attwithfn2231iso-bad
This commit is contained in:
Florian Bruhin 2014-06-19 23:14:20 +02:00
parent 7690e918a2
commit 3c9b4369cd
1 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
qutebrowser/browser/downloads.py
View File

@ -344,8 +344,12 @@ class DownloadManager(QObject):
if reply.hasRawHeader('Content-Disposition'): if reply.hasRawHeader('Content-Disposition'):
# We use the unsafe variant of the filename as we sanitize it via # We use the unsafe variant of the filename as we sanitize it via
# os.path.basename later. # os.path.basename later.
filename = rfc6266.parse_headers( try:
bytes(reply.rawHeader('Content-Disposition'))).filename_unsafe content_disposition = rfc6266.parse_headers(
bytes(reply.rawHeader('Content-Disposition')))
filename = content_disposition.filename_unsafe
except UnicodeDecodeError:
filename = None
else: else:
filename = None filename = None
# Then try to get filename from url # Then try to get filename from url