rnhmjoj/qutebrowser
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Remove fix_urls which isn't needed anymore

Browse Source 
With qute://pdfjs/web/viewer.html we can use relative URLs
This commit is contained in:
Florian Bruhin 2018-09-06 21:39:04 +02:00
parent c40ddf37b7
commit 3ad7ae2a2c
2 changed files with 0 additions and 48 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

27
qutebrowser/browser/pdfjs.py
View File

@ -76,33 +76,6 @@ def _generate_pdfjs_script(url):
).format(url=javascript.string_escape(url.toString(QUrl.FullyEncoded))) ).format(url=javascript.string_escape(url.toString(QUrl.FullyEncoded)))
def fix_urls(asset):
"""Take an html page and replace each relative URL with an absolute.
This is specialized for pdf.js files and not a general purpose function.
Args:
asset: js file or html page as string.
"""
new_urls = [
('viewer.css', 'qute://pdfjs/web/viewer.css'),
('compatibility.js', 'qute://pdfjs/web/compatibility.js'),
('locale/locale.properties',
'qute://pdfjs/web/locale/locale.properties'),
('l10n.js', 'qute://pdfjs/web/l10n.js'),
('../build/pdf.js', 'qute://pdfjs/build/pdf.js'),
('debugger.js', 'qute://pdfjs/web/debugger.js'),
('viewer.js', 'qute://pdfjs/web/viewer.js'),
('compressed.tracemonkey-pldi-09.pdf', ''),
('./images/', 'qute://pdfjs/web/images/'),
('../build/pdf.worker.js', 'qute://pdfjs/build/pdf.worker.js'),
('../web/cmaps/', 'qute://pdfjs/web/cmaps/'),
]
for original, new in new_urls:
asset = asset.replace(original, new)
return asset
SYSTEM_PDFJS_PATHS = [ SYSTEM_PDFJS_PATHS = [
# Debian pdf.js-common # Debian pdf.js-common
# Arch Linux pdfjs (AUR) # Arch Linux pdfjs (AUR)

21
tests/unit/browser/test_pdfjs.py
View File

@ -43,27 +43,6 @@ def test_generate_pdfjs_script(url, expected):
assert 'PDFView' in actual assert 'PDFView' in actual
def test_fix_urls():
page = textwrap.dedent("""
<html>
<script src="viewer.js"></script>
<link href="viewer.css">
<script src="unrelated.js"></script>
</html>
""").strip()
expected = textwrap.dedent("""
<html>
<script src="qute://pdfjs/web/viewer.js"></script>
<link href="qute://pdfjs/web/viewer.css">
<script src="unrelated.js"></script>
</html>
""").strip()
actual = pdfjs.fix_urls(page)
assert actual == expected
@pytest.mark.parametrize('path, expected', [ @pytest.mark.parametrize('path, expected', [
('web/viewer.js', 'viewer.js'), ('web/viewer.js', 'viewer.js'),
('build/locale/foo.bar', 'locale/foo.bar'), ('build/locale/foo.bar', 'locale/foo.bar'),