From 3a73f9f53252bcaf4cdbaf787dab203938625df7 Mon Sep 17 00:00:00 2001 From: Florian Bruhin Date: Wed, 27 Aug 2014 21:03:43 +0200 Subject: [PATCH] Improve performance with statusbar error property --- qutebrowser/widgets/statusbar/bar.py | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/qutebrowser/widgets/statusbar/bar.py b/qutebrowser/widgets/statusbar/bar.py index 41716b47d..eb27f5e5f 100644 --- a/qutebrowser/widgets/statusbar/bar.py +++ b/qutebrowser/widgets/statusbar/bar.py @@ -190,6 +190,11 @@ class StatusBar(QWidget): Re-set the stylesheet after setting the value, so everything gets updated by Qt properly. """ + if self._error == val: + # This gets called a lot (e.g. if the completion selection was + # changed), and setStyleSheet is relatively expensive, so we ignore + # this if there's nothing to change. + return log.statusbar.debug("Setting error to {}".format(val)) self._error = val self.setStyleSheet(style.get_stylesheet(self.STYLESHEET))