From 397ca47efb846a9165ed84db2ec7dfbd31df7cc3 Mon Sep 17 00:00:00 2001 From: Florian Bruhin Date: Tue, 4 Jul 2017 12:31:01 +0200 Subject: [PATCH] Fix vulture --- qutebrowser/keyinput/modeparsers.py | 5 ----- scripts/dev/run_vulture.py | 20 ++++++++++++++++---- 2 files changed, 16 insertions(+), 9 deletions(-) diff --git a/qutebrowser/keyinput/modeparsers.py b/qutebrowser/keyinput/modeparsers.py index 635a265d9..7aa8ca371 100644 --- a/qutebrowser/keyinput/modeparsers.py +++ b/qutebrowser/keyinput/modeparsers.py @@ -322,8 +322,3 @@ class RegisterKeyParser(keyparser.CommandKeyParser): self.request_leave.emit(self._mode, "valid register key", True) return True - - @pyqtSlot(str) - def on_keyconfig_changed(self, mode): - """RegisterKeyParser has no config section (no bindable keys).""" - pass diff --git a/scripts/dev/run_vulture.py b/scripts/dev/run_vulture.py index 8a1886e11..0d4f8dabb 100755 --- a/scripts/dev/run_vulture.py +++ b/scripts/dev/run_vulture.py @@ -38,6 +38,7 @@ from qutebrowser.browser.webkit import rfc6266 from qutebrowser.browser.webkit.network import webkitqutescheme # pylint: enable=unused-import from qutebrowser.browser import qutescheme +from qutebrowser.config import configtypes def whitelist_generator(): @@ -63,7 +64,6 @@ def whitelist_generator(): yield 'qutebrowser.utils.debug.qflags_key' yield 'qutebrowser.utils.qtutils.QtOSError.qt_errno' yield 'scripts.utils.bg_colors' - yield 'qutebrowser.config.configtypes.Float' # Qt attributes yield 'PyQt5.QtWebKit.QWebPage.ErrorPageExtensionReturn().baseUrl' @@ -93,11 +93,23 @@ def whitelist_generator(): for attr in ['fileno', 'truncate', 'closed', 'readable']: yield 'qutebrowser.utils.qtutils.PyQIODevice.' + attr - for attr in ['priority', 'visit_call']: + for attr in ['msgs', 'priority', 'visit_attribute']: yield 'scripts.dev.pylint_checkers.config.' + attr + for attr in ['visit_call', 'process_module']: + yield 'scripts.dev.pylint_checkers.modeline.' + attr - yield 'scripts.dev.pylint_checkers.modeline.process_module' - yield 'scripts.dev.pylint_checkers.qute_pylint.config.msgs' + for name, member in inspect.getmembers(configtypes, inspect.isclass): + yield 'qutebrowser.config.configtypes.' + name + + ### FIXME:conf + ## completion + for name in ['Section', 'Option', 'Value']: + klass = 'Setting{}CompletionModel'.format(name) + yield 'qutebrowser.completion.models.configmodel.' + klass + # in qutebrowser.completion.models.miscmodels._get_cmd_completions + yield 'include_aliases' + ## FIXME:conf TODO + yield 'qutebrowser.config.configdata.DEFAULT_FONT_SIZE' for attr in ['_get_default_metavar_for_optional', '_get_default_metavar_for_positional', '_metavar_formatter']: