rnhmjoj/qutebrowser
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Stabilize history tests

Browse Source 
Get current URL right away in :view-source, and wait until source is shown in
the test.
This commit is contained in:
Florian Bruhin 2017-06-12 18:13:17 +02:00
parent b687ede25c
commit 38d54cb112
2 changed files with 7 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
qutebrowser/browser/commands.py
View File

@ -1450,14 +1450,14 @@ class CommandDispatcher:
if tab.data.viewing_source: if tab.data.viewing_source:
raise cmdexc.CommandError("Already viewing source!") raise cmdexc.CommandError("Already viewing source!")
try:
current_url = self._current_url()
except cmdexc.CommandError as e:
message.error(str(e))
return
def show_source_cb(source): def show_source_cb(source):
"""Show source as soon as it's ready.""" """Show source as soon as it's ready."""
try:
current_url = self._current_url()
except cmdexc.CommandError as e:
message.error(str(e))
return
lexer = pygments.lexers.HtmlLexer() lexer = pygments.lexers.HtmlLexer()
formatter = pygments.formatters.HtmlFormatter( formatter = pygments.formatters.HtmlFormatter(
full=True, linenos='table', full=True, linenos='table',

1
tests/end2end/features/history.feature
View File

@ -67,6 +67,7 @@ Feature: Page history
Scenario: History with view-source URL Scenario: History with view-source URL
When I open data/title.html When I open data/title.html
And I run :view-source And I run :view-source
And I wait for "Changing title for idx * to 'Source for http://localhost:*/data/title.html'" in the log
Then the history file should contain: Then the history file should contain:
http://localhost:(port)/data/title.html Test title http://localhost:(port)/data/title.html Test title