From 3b0354518bc60205dc275757c36b78738bb66c29 Mon Sep 17 00:00:00 2001 From: Liam BEGUIN Date: Sun, 15 May 2016 22:46:12 -0400 Subject: [PATCH 1/7] Added basic inputs-group to :hint --- qutebrowser/browser/webelem.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/qutebrowser/browser/webelem.py b/qutebrowser/browser/webelem.py index e47a67235..39f4776d6 100644 --- a/qutebrowser/browser/webelem.py +++ b/qutebrowser/browser/webelem.py @@ -38,7 +38,7 @@ from qutebrowser.utils import log, usertypes, utils Group = usertypes.enum('Group', ['all', 'links', 'images', 'url', 'prevnext', - 'focus']) + 'focus', 'inputs']) SELECTORS = { @@ -50,6 +50,7 @@ SELECTORS = { Group.url: '[src], [href]', Group.prevnext: 'a, area, button, link, [role=button]', Group.focus: '*:focus', + Group.inputs: 'input[type=text], input[type=password], textarea', } From 531a5071f65aaeedb9af5843146192ae416015d3 Mon Sep 17 00:00:00 2001 From: Liam BEGUIN Date: Tue, 17 May 2016 00:38:23 -0400 Subject: [PATCH 2/7] updated inputs-group --- qutebrowser/browser/webelem.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/qutebrowser/browser/webelem.py b/qutebrowser/browser/webelem.py index 39f4776d6..78dbffa1e 100644 --- a/qutebrowser/browser/webelem.py +++ b/qutebrowser/browser/webelem.py @@ -50,7 +50,9 @@ SELECTORS = { Group.url: '[src], [href]', Group.prevnext: 'a, area, button, link, [role=button]', Group.focus: '*:focus', - Group.inputs: 'input[type=text], input[type=password], textarea', + Group.inputs: ('input[type=text], input[type=email], input[type=url], ' + 'input[type=tel], input[type=number], input[type=password], ' + 'input[type=search], textarea'), } From b66d5e1ce92f4dbfc25baa3e9e00efd168cdafc2 Mon Sep 17 00:00:00 2001 From: Liam BEGUIN Date: Tue, 17 May 2016 19:58:27 -0400 Subject: [PATCH 3/7] Fixed indentations --- qutebrowser/browser/webelem.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/qutebrowser/browser/webelem.py b/qutebrowser/browser/webelem.py index 78dbffa1e..f63417884 100644 --- a/qutebrowser/browser/webelem.py +++ b/qutebrowser/browser/webelem.py @@ -51,8 +51,8 @@ SELECTORS = { Group.prevnext: 'a, area, button, link, [role=button]', Group.focus: '*:focus', Group.inputs: ('input[type=text], input[type=email], input[type=url], ' - 'input[type=tel], input[type=number], input[type=password], ' - 'input[type=search], textarea'), + 'input[type=tel], input[type=number], input[type=password], ' + 'input[type=search], textarea'), } From ce0d23bd10d6d716b87d59d2ca3570d11a198be1 Mon Sep 17 00:00:00 2001 From: Liam BEGUIN Date: Tue, 17 May 2016 19:58:48 -0400 Subject: [PATCH 4/7] Added tests for the inputs group --- tests/unit/browser/test_webelem.py | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/tests/unit/browser/test_webelem.py b/tests/unit/browser/test_webelem.py index 459a8b1b1..220ba237a 100644 --- a/tests/unit/browser/test_webelem.py +++ b/tests/unit/browser/test_webelem.py @@ -128,11 +128,18 @@ class SelectionAndFilterTests: ('', [webelem.Group.all, webelem.Group.url]), - ('