rnhmjoj/qutebrowser
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Add test for invalid value type in YAML file

Browse Source
This commit is contained in:
Florian Bruhin 2017-09-21 20:41:30 +02:00
parent b1ddb9a6df
commit 32b2b3dfd9
1 changed files with 16 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
tests/unit/config/test_config.py
View File

@ -891,7 +891,8 @@ def init_patch(qapp, fake_save_manager, monkeypatch, config_tmpdir,
@pytest.mark.parametrize('load_autoconfig', [True, False]) # noqa @pytest.mark.parametrize('load_autoconfig', [True, False]) # noqa
@pytest.mark.parametrize('config_py', [True, 'error', False]) @pytest.mark.parametrize('config_py', [True, 'error', False])
@pytest.mark.parametrize('invalid_yaml', ['42', 'unknown', False]) @pytest.mark.parametrize('invalid_yaml',
['42', 'unknown', 'wrong-type', False])
# pylint: disable=too-many-branches # pylint: disable=too-many-branches
def test_early_init(init_patch, config_tmpdir, caplog, fake_args, def test_early_init(init_patch, config_tmpdir, caplog, fake_args,
load_autoconfig, config_py, invalid_yaml): load_autoconfig, config_py, invalid_yaml):
@ -900,14 +901,15 @@ def test_early_init(init_patch, config_tmpdir, caplog, fake_args,
config_py_file = config_tmpdir / 'config.py' config_py_file = config_tmpdir / 'config.py'
if invalid_yaml == '42': if invalid_yaml == '42':
autoconfig_file.write_text('42', 'utf-8', ensure=True) text = '42'
elif invalid_yaml == 'unknown': elif invalid_yaml == 'unknown':
autoconfig_file.write_text('global:\n colors.foobar: magenta\n', text = 'global:\n colors.foobar: magenta\n'
'utf-8', ensure=True) elif invalid_yaml == 'wrong-type':
text = 'global:\n tabs.position: true\n'
else: else:
assert not invalid_yaml assert not invalid_yaml
autoconfig_file.write_text('global:\n colors.hints.fg: magenta\n', text = 'global:\n colors.hints.fg: magenta\n'
'utf-8', ensure=True) autoconfig_file.write_text(text, 'utf-8', ensure=True)
if config_py: if config_py:
config_py_lines = ['c.colors.hints.bg = "red"'] config_py_lines = ['c.colors.hints.bg = "red"']
@ -927,10 +929,15 @@ def test_early_init(init_patch, config_tmpdir, caplog, fake_args,
expected_errors.append( expected_errors.append(
"Errors occurred while reading config.py:\n" "Errors occurred while reading config.py:\n"
" While setting 'foo': No option 'foo'") " While setting 'foo': No option 'foo'")
if invalid_yaml == '42' and (load_autoconfig or not config_py): if load_autoconfig or not config_py:
error = "Errors occurred while reading autoconfig.yml:\n" error = "Errors occurred while reading autoconfig.yml:\n"
if invalid_yaml == '42':
error += " While loading data: Toplevel object is not a dict" error += " While loading data: Toplevel object is not a dict"
expected_errors.append(error) expected_errors.append(error)
elif invalid_yaml == 'wrong-type':
error += (" Error: Invalid value 'True' - expected a value of "
"type str but got bool.")
expected_errors.append(error)
actual_errors = [str(err) for err in config._init_errors] actual_errors = [str(err) for err in config._init_errors]
assert actual_errors == expected_errors assert actual_errors == expected_errors