rnhmjoj/qutebrowser
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Fix match highlighting on qt 5.11.3 and 5.12.1+

Browse Source 
For some reason, populating the text (even if we completely overwrite
it later) before the highlighter is added results in no highlighting.
I think this has something to do with python locking/delayed
re-highlighting.

At some point, it would be nice to file this as a bug, but I can't
seem to make a small c++ example.

See https://codereview.qt-project.org/#/c/244699/4//ALL and
https://bugreports.qt.io/browse/QTBUG-71307 for more information.

Closes #4519
This commit is contained in:
Jay Kamat 2019-01-12 10:10:05 -08:00
parent cc0f5fc6d4
commit 322b4d26d8
No known key found for this signature in database
GPG Key ID: 5D2E399600F4F7B5
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
qutebrowser/completion/completiondelegate.py
View File

@ -212,11 +212,11 @@ class CompletionItemDelegate(QStyledItemDelegate):
view = self.parent() view = self.parent()
pattern = view.pattern pattern = view.pattern
columns_to_filter = index.model().columns_to_filter(index) columns_to_filter = index.model().columns_to_filter(index)
self._doc.setPlainText(self._opt.text)
if index.column() in columns_to_filter and pattern: if index.column() in columns_to_filter and pattern:
pat = re.escape(pattern).replace(r'\ ', r'|') pat = re.escape(pattern).replace(r'\ ', r'|')
_Highlighter(self._doc, pat, _Highlighter(self._doc, pat,
config.val.colors.completion.match.fg) config.val.colors.completion.match.fg)
self._doc.setPlainText(self._opt.text)
else: else:
self._doc.setHtml( self._doc.setHtml(
'<span style="font: {};">{}</span>'.format( '<span style="font: {};">{}</span>'.format(