rnhmjoj/qutebrowser
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Split _inject_greasemonkey_scripts to separate requirements.

Browse Source 
Because flake8 was complaining about cyclomatic complexity.
This commit is contained in:
Jimmy 2018-09-09 14:00:53 +12:00
parent abea603119
commit 32268ae66a
1 changed files with 10 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
qutebrowser/browser/webengine/webenginetab.py
View File

@ -911,6 +911,15 @@ class _WebEngineScripts(QObject):
scripts = self._greasemonkey.all_scripts() scripts = self._greasemonkey.all_scripts()
self._inject_greasemonkey_scripts(scripts) self._inject_greasemonkey_scripts(scripts)
def _remove_all_greasemonkey_scripts(self):
page_scripts = self._widget.page().scripts()
for script in page_scripts.toList():
if script.name().startswith("GM-"):
log.greasemonkey.debug('Removing script: {}'
.format(script.name()))
removed = page_scripts.remove(script)
assert removed, script.name()
def _inject_greasemonkey_scripts(self, scripts=None, injection_point=None, def _inject_greasemonkey_scripts(self, scripts=None, injection_point=None,
remove_first=True): remove_first=True):
"""Register user JavaScript files with the current tab. """Register user JavaScript files with the current tab.
@ -934,12 +943,7 @@ class _WebEngineScripts(QObject):
# have been added elsewhere, like the one for stylesheets. # have been added elsewhere, like the one for stylesheets.
page_scripts = self._widget.page().scripts() page_scripts = self._widget.page().scripts()
if remove_first: if remove_first:
for script in page_scripts.toList(): self._remove_all_greasemonkey_scripts()
if script.name().startswith("GM-"):
log.greasemonkey.debug('Removing script: {}'
.format(script.name()))
removed = page_scripts.remove(script)
assert removed, script.name()
if not scripts: if not scripts:
return return