diff --git a/scripts/dev/check_coverage.py b/scripts/dev/check_coverage.py index c03ffa2df..aa957e3a6 100644 --- a/scripts/dev/check_coverage.py +++ b/scripts/dev/check_coverage.py @@ -120,12 +120,7 @@ def check(fileobj, perfect_files): assert 0 <= branch_cov <= 100, branch_cov assert '\\' not in filename, filename - # Files without any branches have 0% coverage - has_branches = klass.find('./lines/line[@branch="true"]') is not None - if branch_cov < 100 and has_branches: - is_bad = True - else: - is_bad = line_cov < 100 + is_bad = line_cov < 100 or branch_cov < 100 if filename in perfect_files and is_bad: messages.append(("{} has {}% line and {}% branch coverage!".format( diff --git a/tests/unit/scripts/test_check_coverage.py b/tests/unit/scripts/test_check_coverage.py index 26fc6bdf1..e9df9644c 100644 --- a/tests/unit/scripts/test_check_coverage.py +++ b/tests/unit/scripts/test_check_coverage.py @@ -126,7 +126,7 @@ def test_untested(covtest): pass """) covtest.run() - expected = 'module.py has 75.0% line and 0.0% branch coverage!' + expected = 'module.py has 75.0% line and 100.0% branch coverage!' assert covtest.check() == [expected]