rnhmjoj/qutebrowser
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Only set PDFJS.disableCreateObjectURL when necessary

Browse Source 
See #4198
This commit is contained in:
Florian Bruhin 2018-09-06 21:57:18 +02:00
parent 6665a1348e
commit 2dccde8f4b
1 changed files with 10 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
qutebrowser/browser/pdfjs.py
View File

@ -24,7 +24,8 @@ import os
from PyQt5.QtCore import QUrl, QUrlQuery from PyQt5.QtCore import QUrl, QUrlQuery
from qutebrowser.utils import utils, javascript, jinja from qutebrowser.utils import utils, javascript, jinja, qtutils, usertypes
from qutebrowser.misc import objects
from qutebrowser.config import config from qutebrowser.config import config
@ -69,11 +70,18 @@ def _generate_pdfjs_script(url):
""" """
return jinja.js_environment.from_string(""" return jinja.js_environment.from_string("""
document.addEventListener("DOMContentLoaded", function() { document.addEventListener("DOMContentLoaded", function() {
{% if disable_create_object_url %}
PDFJS.disableCreateObjectURL = true; PDFJS.disableCreateObjectURL = true;
{% endif %}
PDFJS.verbosity = PDFJS.VERBOSITY_LEVELS.info; PDFJS.verbosity = PDFJS.VERBOSITY_LEVELS.info;
(window.PDFView || window.PDFViewerApplication).open("{{ url }}"); (window.PDFView || window.PDFViewerApplication).open("{{ url }}");
}); });
""").render(url=javascript.string_escape(url.toString(QUrl.FullyEncoded))) """).render(
url=javascript.string_escape(url.toString(QUrl.FullyEncoded)),
# WORKAROUND for https://bugreports.qt.io/browse/QTBUG-70420
disable_create_object_url=(
not qtutils.version_check('5.12') and
objects.backend == usertypes.Backend.QtWebEngine))
SYSTEM_PDFJS_PATHS = [ SYSTEM_PDFJS_PATHS = [