rnhmjoj/qutebrowser
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Fix urlutils tests on Qt 5.6.1

Browse Source 
For some reason the behaviour of QHostAddress("31c3").isValid() changed
with Qt 5.6.1: https://bugreports.qt.io/browse/QTBUG-53983

This causes the test to fail because Qt thinks this is a valid IP, so we
think it's a valid URL.
This commit is contained in:
Florian Bruhin 2016-06-09 15:16:49 +02:00
parent c390c797b2
commit 2d54c927e3
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
tests/unit/utils/test_urlutils.py
View File

@ -336,7 +336,9 @@ def test_get_search_url_invalid(urlutils_config_stub, url):
(False, True, False, '23.42'), # no DNS because bogus-IP (False, True, False, '23.42'), # no DNS because bogus-IP
(False, True, False, '1337'), # no DNS because bogus-IP (False, True, False, '1337'), # no DNS because bogus-IP
(False, True, True, 'deadbeef'), (False, True, True, 'deadbeef'),
(False, True, False, '31c3'), # no DNS because bogus-IP pytest.mark.xfail(qtutils.version_check('5.6.1'),
reason='Qt behaviour changed')(
False, True, False, '31c3'), # no DNS because bogus-IP
(False, True, False, 'foo::bar'), # no DNS because of no host (False, True, False, 'foo::bar'), # no DNS because of no host
# Valid search term with autosearch # Valid search term with autosearch
(False, False, False, 'test foo'), (False, False, False, 'test foo'),