From 2c4e549d803136788e8269cdced404817a133c5c Mon Sep 17 00:00:00 2001 From: Florian Bruhin Date: Wed, 29 Mar 2017 08:46:46 +0200 Subject: [PATCH] Close temporary download file for QtWebEngine Otherwise, Chromium won't be able to write on it on Windows - and we only need the name anyways. --- qutebrowser/browser/webengine/webenginedownloads.py | 1 + tests/end2end/features/downloads.feature | 1 - 2 files changed, 1 insertion(+), 1 deletion(-) diff --git a/qutebrowser/browser/webengine/webenginedownloads.py b/qutebrowser/browser/webengine/webenginedownloads.py index e20440b69..53cbb82c1 100644 --- a/qutebrowser/browser/webengine/webenginedownloads.py +++ b/qutebrowser/browser/webengine/webenginedownloads.py @@ -104,6 +104,7 @@ class DownloadItem(downloads.AbstractDownloadItem): raise downloads.UnsupportedOperationError def _set_tempfile(self, fileobj): + fileobj.close() self._set_filename(fileobj.name, force_overwrite=True, remember_directory=False) diff --git a/tests/end2end/features/downloads.feature b/tests/end2end/features/downloads.feature index b862f9c74..c78416abe 100644 --- a/tests/end2end/features/downloads.feature +++ b/tests/end2end/features/downloads.feature @@ -419,7 +419,6 @@ Feature: Downloading things from a website. ## opening a file directly (prompt-open-download) - @issue2478 Scenario: Opening a download directly When I set storage -> prompt-download-directory to true And I open data/downloads/download.bin without waiting