rnhmjoj/qutebrowser
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

100% coverage for keyinput.keyutils

Browse Source
This commit is contained in:
Florian Bruhin 2018-03-04 19:12:24 +01:00
parent 8da878c77c
commit 2be7db29ed
3 changed files with 27 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
qutebrowser/keyinput/keyutils.py
View File

@ -391,7 +391,7 @@ class KeySequence:
return QKeySequence.ExactMatch return QKeySequence.ExactMatch
elif len(self._sequences) < len(other._sequences): elif len(self._sequences) < len(other._sequences):
return QKeySequence.PartialMatch return QKeySequence.PartialMatch
else: else: # pragma: no cover
assert False, (self, other) assert False, (self, other)
def append_event(self, ev): def append_event(self, ev):

2
scripts/dev/check_coverage.py
View File

@ -86,6 +86,8 @@ PERFECT_FILES = [
('tests/unit/keyinput/test_basekeyparser.py', ('tests/unit/keyinput/test_basekeyparser.py',
'keyinput/basekeyparser.py'), 'keyinput/basekeyparser.py'),
('tests/unit/keyinput/test_keyutils.py',
'keyinput/keyutils.py'),
('tests/unit/misc/test_autoupdate.py', ('tests/unit/misc/test_autoupdate.py',
'misc/autoupdate.py'), 'misc/autoupdate.py'),

24
tests/unit/keyinput/test_keyutils.py
View File

@ -320,6 +320,30 @@ class TestKeySequence:
configured = keyutils.KeySequence.parse(configured) configured = keyutils.KeySequence.parse(configured)
assert entered.matches(configured) == expected assert entered.matches(configured) == expected
@pytest.mark.parametrize('old, key, modifiers, text, expected', [
('a', Qt.Key_B, Qt.NoModifier, 'b', 'ab'),
('a', Qt.Key_B, Qt.ShiftModifier, 'B', 'aB'),
('a', Qt.Key_B, Qt.ControlModifier | Qt.ShiftModifier, 'B',
'a<Ctrl+Shift+b>'),
# Modifier stripping with symbols
('', Qt.Key_Colon, Qt.NoModifier, ':', ':'),
('', Qt.Key_Colon, Qt.ShiftModifier, ':', ':'),
('', Qt.Key_Colon, Qt.ControlModifier | Qt.ShiftModifier, ':',
'<Ctrl+Shift+:>'),
# Handling of Backtab
('', Qt.Key_Backtab, Qt.NoModifier, '', '<Backtab>'),
('', Qt.Key_Backtab, Qt.ShiftModifier, '', '<Shift+Tab>'),
('', Qt.Key_Backtab, Qt.ControlModifier | Qt.ShiftModifier, '',
'<Control+Shift+Tab>'),
])
def test_append_event(self, old, key, modifiers, text, expected):
seq = keyutils.KeySequence.parse(old)
event = QKeyEvent(QKeyEvent.KeyPress, key, modifiers, text)
new = seq.append_event(event)
assert new == keyutils.KeySequence.parse(expected)
@pytest.mark.parametrize('keystr, expected', [ @pytest.mark.parametrize('keystr, expected', [
('<Control-x>', keyutils.KeySequence(Qt.ControlModifier | Qt.Key_X)), ('<Control-x>', keyutils.KeySequence(Qt.ControlModifier | Qt.Key_X)),
('<Meta-x>', keyutils.KeySequence(Qt.MetaModifier | Qt.Key_X)), ('<Meta-x>', keyutils.KeySequence(Qt.MetaModifier | Qt.Key_X)),