rnhmjoj/qutebrowser
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Add some assertions for 'successful'.

Browse Source
This commit is contained in:
Florian Bruhin 2014-11-18 19:56:57 +01:00
parent b1d6e70c8b
commit 2a95533564
1 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
qutebrowser/browser/downloads.py
View File

@ -159,6 +159,7 @@ class DownloadItem(QObject):
def _die(self, msg): def _die(self, msg):
"""Abort the download and emit an error.""" """Abort the download and emit an error."""
assert not self.successful
self._reply.downloadProgress.disconnect() self._reply.downloadProgress.disconnect()
self._reply.finished.disconnect() self._reply.finished.disconnect()
self._reply.error.disconnect() self._reply.error.disconnect()
@ -204,6 +205,7 @@ class DownloadItem(QObject):
system = config.get('colors', 'downloads.bg.system') system = config.get('colors', 'downloads.bg.system')
error = config.get('colors', 'downloads.bg.error') error = config.get('colors', 'downloads.bg.error')
if self.error_msg is not None: if self.error_msg is not None:
assert not self.successful
return error return error
elif self._percentage() is None: elif self._percentage() is None:
return start return start
@ -537,8 +539,10 @@ class DownloadManager(QAbstractListModel):
data = item data = item
elif role == Qt.ToolTipRole: elif role == Qt.ToolTipRole:
if item.error_msg is None: if item.error_msg is None:
assert item.successful
data = QVariant() data = QVariant()
else: else:
assert not item.successful
return item.error_msg return item.error_msg
else: else:
data = QVariant() data = QVariant()