From 2918c5cd57be08b1f1544d802fc225ef84ac35be Mon Sep 17 00:00:00 2001 From: Daniel Schadt Date: Fri, 6 May 2016 18:01:45 +0200 Subject: [PATCH] downloads: close fileobject in DownloadItem._die Otherwise we will get a unclosed resource warning. --- qutebrowser/browser/downloads.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/qutebrowser/browser/downloads.py b/qutebrowser/browser/downloads.py index 85c957fb9..6cbeff434 100644 --- a/qutebrowser/browser/downloads.py +++ b/qutebrowser/browser/downloads.py @@ -412,6 +412,8 @@ class DownloadItem(QObject): self.reply = None self.done = True self.data_changed.emit() + if self.fileobj is not None: + self.fileobj.close() def init_reply(self, reply): """Set a new reply and connect its signals.