rnhmjoj/qutebrowser
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Merge branch 'Kingdread-fast-open-download'

Browse Source
This commit is contained in:
Florian Bruhin 2017-03-05 15:51:35 +01:00
commit 271cb3be3d
2 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
CHANGELOG.asciidoc
View File

@ -41,6 +41,7 @@ Fixed
- The cursor now moves to the end when input elements are selected with QtWebEngine - The cursor now moves to the end when input elements are selected with QtWebEngine
- Download suffixes like (1) are now correctly stripped with QtWebEngine - Download suffixes like (1) are now correctly stripped with QtWebEngine
- Crash when trying to print a tab which was closed in the meantime - Crash when trying to print a tab which was closed in the meantime
- Crash when trying to open a file twice on Windows
v0.10.0 v0.10.0
------- -------

6
qutebrowser/browser/downloads.py
View File

@ -529,7 +529,11 @@ class AbstractDownloadItem(QObject):
if filename is None: # pragma: no cover if filename is None: # pragma: no cover
log.downloads.error("No filename to open the download!") log.downloads.error("No filename to open the download!")
return return
utils.open_file(filename, cmdline) # By using a singleshot timer, we ensure that we return fast. This
# is important on systems where process creation takes long, as
# otherwise the prompt might hang around and cause bugs
# (see issue #2296)
QTimer.singleShot(0, lambda: utils.open_file(filename, cmdline))
def _ensure_can_set_filename(self, filename): def _ensure_can_set_filename(self, filename):
"""Make sure we can still set a filename.""" """Make sure we can still set a filename."""