Rewrite browser.test_tabhistory.py for pytest.
This commit is contained in:
Florian Bruhin
parent
0e25f5c730
commit
26f6bb7d0d
@ -35,6 +35,7 @@ PERFECT_FILES = [
|
||||
'qutebrowser/commands/cmdexc.py',
|
||||
'qutebrowser/config/configtypes.py',
|
||||
'qutebrowser/misc/readline.py',
|
||||
'qutebrowser/browser/tabhistory.py',
|
||||
|
||||
'qutebrowser/utils/qtutils.py',
|
||||
'qutebrowser/utils/standarddir.py',
|
||||
|
||||
@ -19,6 +19,8 @@
|
||||
|
||||
"""Tests for webelement.tabhistory."""
|
||||
|
||||
import collections
|
||||
|
||||
from PyQt5.QtCore import QUrl, QPoint
|
||||
import pytest
|
||||
|
||||
@ -27,113 +29,115 @@ from qutebrowser.browser.tabhistory import TabHistoryItem as Item
|
||||
from qutebrowser.utils import qtutils
|
||||
|
||||
|
||||
class TestSerializeHistory:
|
||||
|
||||
"""Tests for serialize()."""
|
||||
|
||||
ITEMS = [
|
||||
Item(QUrl('https://www.heise.de/'), QUrl('http://www.heise.de/'),
|
||||
'heise'),
|
||||
Item(QUrl('http://example.com/%E2%80%A6'),
|
||||
QUrl('http://example.com/%E2%80%A6'), 'percent', active=True),
|
||||
Item(QUrl('http://example.com/?foo=bar'),
|
||||
QUrl('http://original.url.example.com/'), 'arg',
|
||||
user_data={'foo': 23, 'bar': 42}),
|
||||
# From https://github.com/OtterBrowser/otter-browser/issues/709#issuecomment-74749471
|
||||
Item(
|
||||
QUrl('http://github.com/OtterBrowser/24/134/2344/otter-browser/'
|
||||
'issues/709/'),
|
||||
QUrl('http://github.com/OtterBrowser/24/134/2344/otter-browser/'
|
||||
'issues/709/'),
|
||||
'Page not found | github',
|
||||
user_data={'zoom': 149, 'scroll-pos': QPoint(0, 0)}),
|
||||
Item(
|
||||
QUrl('https://mail.google.com/mail/u/0/#label/some+label/'
|
||||
'234lkjsd0932lkjf884jqwerdf4'),
|
||||
QUrl('https://mail.google.com/mail/u/0/#label/some+label/'
|
||||
'234lkjsd0932lkjf884jqwerdf4'),
|
||||
'"some label" - email@gmail.com - Gmail"',
|
||||
user_data={'zoom': 120, 'scroll-pos': QPoint(0, 0)}),
|
||||
]
|
||||
|
||||
@pytest.fixture(autouse=True)
|
||||
def setup(self, webpage):
|
||||
self.page = webpage
|
||||
self.history = self.page.history()
|
||||
assert self.history.count() == 0
|
||||
|
||||
stream, _data, self.user_data = tabhistory.serialize(self.ITEMS)
|
||||
qtutils.deserialize_stream(stream, self.history)
|
||||
|
||||
def test_count(self):
|
||||
"""Check if the history's count was loaded correctly."""
|
||||
assert self.history.count() == len(self.ITEMS)
|
||||
|
||||
@pytest.mark.parametrize('i', range(len(ITEMS)))
|
||||
def test_valid(self, i):
|
||||
"""Check if all items are valid."""
|
||||
assert self.history.itemAt(i).isValid()
|
||||
|
||||
@pytest.mark.parametrize('i', range(len(ITEMS)))
|
||||
def test_no_userdata(self, i):
|
||||
"""Check if all items have no user data."""
|
||||
assert self.history.itemAt(i).userData() is None
|
||||
|
||||
def test_userdata(self):
|
||||
"""Check if all user data has been restored to self.user_data."""
|
||||
userdata_items = [item.user_data for item in self.ITEMS]
|
||||
assert userdata_items == self.user_data
|
||||
|
||||
def test_currentitem(self):
|
||||
"""Check if the current item index was loaded correctly."""
|
||||
assert self.history.currentItemIndex() == 1
|
||||
|
||||
@pytest.mark.parametrize('i, item', enumerate(ITEMS))
|
||||
def test_urls(self, i, item):
|
||||
"""Check if the URLs were loaded correctly."""
|
||||
assert self.history.itemAt(i).url() == item.url
|
||||
|
||||
@pytest.mark.parametrize('i, item', enumerate(ITEMS))
|
||||
def test_original_urls(self, i, item):
|
||||
"""Check if the original URLs were loaded correctly."""
|
||||
assert self.history.itemAt(i).originalUrl() == item.original_url
|
||||
|
||||
@pytest.mark.parametrize('i, item', enumerate(ITEMS))
|
||||
def test_titles(self, i, item):
|
||||
"""Check if the titles were loaded correctly."""
|
||||
assert self.history.itemAt(i).title() == item.title
|
||||
ITEMS = [
|
||||
Item(QUrl('https://www.heise.de/'), QUrl('http://www.heise.de/'), 'heise'),
|
||||
Item(QUrl('http://example.com/%E2%80%A6'),
|
||||
QUrl('http://example.com/%E2%80%A6'), 'percent', active=True),
|
||||
Item(QUrl('http://example.com/?foo=bar'),
|
||||
QUrl('http://original.url.example.com/'), 'arg',
|
||||
user_data={'foo': 23, 'bar': 42}),
|
||||
# From https://github.com/OtterBrowser/otter-browser/issues/709#issuecomment-74749471
|
||||
Item(QUrl('http://github.com/OtterBrowser/24/134/2344/otter-browser/issues/'
|
||||
'709/'),
|
||||
QUrl('http://github.com/OtterBrowser/24/134/2344/otter-browser/issues/'
|
||||
'709/'),
|
||||
'Page not found | github',
|
||||
user_data={'zoom': 149, 'scroll-pos': QPoint(0, 0)}),
|
||||
Item(QUrl('https://mail.google.com/mail/u/0/#label/some+label/'
|
||||
'234lkjsd0932lkjf884jqwerdf4'),
|
||||
QUrl('https://mail.google.com/mail/u/0/#label/some+label/'
|
||||
'234lkjsd0932lkjf884jqwerdf4'),
|
||||
'"some label" - email@gmail.com - Gmail"',
|
||||
user_data={'zoom': 120, 'scroll-pos': QPoint(0, 0)}),
|
||||
]
|
||||
|
||||
|
||||
class TestSerializeHistorySpecial:
|
||||
Objects = collections.namedtuple('Objects', 'history, user_data')
|
||||
|
||||
"""Tests for serialize() without items set up in setup."""
|
||||
|
||||
@pytest.fixture(autouse=True)
|
||||
def setup(self, webpage):
|
||||
"""Set up the initial QWebPage for each test."""
|
||||
self.page = webpage
|
||||
self.history = self.page.history()
|
||||
assert self.history.count() == 0
|
||||
@pytest.fixture
|
||||
def empty_history(webpage):
|
||||
"""Fixture providing an empty QWebHistory."""
|
||||
hist = webpage.history()
|
||||
assert hist.count() == 0
|
||||
return hist
|
||||
|
||||
def test_no_active_item(self):
|
||||
"""Check tabhistory.serialize with no active item."""
|
||||
items = [Item(QUrl(), QUrl(), '')]
|
||||
with pytest.raises(ValueError):
|
||||
tabhistory.serialize(items)
|
||||
|
||||
def test_two_active_items(self):
|
||||
"""Check tabhistory.serialize with two active items."""
|
||||
items = [Item(QUrl(), QUrl(), '', active=True),
|
||||
Item(QUrl(), QUrl(), ''),
|
||||
Item(QUrl(), QUrl(), '', active=True)]
|
||||
with pytest.raises(ValueError):
|
||||
tabhistory.serialize(items)
|
||||
@pytest.fixture
|
||||
def objects(empty_history):
|
||||
"""Fixture providing a history (and userdata) filled with example data."""
|
||||
stream, _data, user_data = tabhistory.serialize(ITEMS)
|
||||
qtutils.deserialize_stream(stream, empty_history)
|
||||
return Objects(history=empty_history, user_data=user_data)
|
||||
|
||||
def test_empty(self):
|
||||
"""Check tabhistory.serialize with no items."""
|
||||
items = []
|
||||
stream, _data, user_data = tabhistory.serialize(items)
|
||||
qtutils.deserialize_stream(stream, self.history)
|
||||
assert self.history.count() == 0
|
||||
assert self.history.currentItemIndex() == 0
|
||||
assert not user_data
|
||||
|
||||
def test_count(objects):
|
||||
"""Check if the history's count was loaded correctly."""
|
||||
assert objects.history.count() == len(ITEMS)
|
||||
|
||||
|
||||
@pytest.mark.parametrize('i', range(len(ITEMS)))
|
||||
def test_valid(objects, i):
|
||||
"""Check if all items are valid."""
|
||||
assert objects.history.itemAt(i).isValid()
|
||||
|
||||
|
||||
@pytest.mark.parametrize('i', range(len(ITEMS)))
|
||||
def test_no_userdata(objects, i):
|
||||
"""Check if all items have no user data."""
|
||||
assert objects.history.itemAt(i).userData() is None
|
||||
|
||||
|
||||
def test_userdata(objects):
|
||||
"""Check if all user data has been restored to user_data."""
|
||||
userdata_items = [item.user_data for item in ITEMS]
|
||||
assert userdata_items == objects.user_data
|
||||
|
||||
|
||||
def test_currentitem(objects):
|
||||
"""Check if the current item index was loaded correctly."""
|
||||
assert objects.history.currentItemIndex() == 1
|
||||
|
||||
|
||||
@pytest.mark.parametrize('i, item', enumerate(ITEMS))
|
||||
def test_urls(objects, i, item):
|
||||
"""Check if the URLs were loaded correctly."""
|
||||
assert objects.history.itemAt(i).url() == item.url
|
||||
|
||||
|
||||
@pytest.mark.parametrize('i, item', enumerate(ITEMS))
|
||||
def test_original_urls(objects, i, item):
|
||||
"""Check if the original URLs were loaded correctly."""
|
||||
assert objects.history.itemAt(i).originalUrl() == item.original_url
|
||||
|
||||
|
||||
@pytest.mark.parametrize('i, item', enumerate(ITEMS))
|
||||
def test_titles(objects, i, item):
|
||||
"""Check if the titles were loaded correctly."""
|
||||
assert objects.history.itemAt(i).title() == item.title
|
||||
|
||||
|
||||
def test_no_active_item():
|
||||
"""Check tabhistory.serialize with no active item."""
|
||||
items = [Item(QUrl(), QUrl(), '')]
|
||||
with pytest.raises(ValueError):
|
||||
tabhistory.serialize(items)
|
||||
|
||||
|
||||
def test_two_active_items():
|
||||
"""Check tabhistory.serialize with two active items."""
|
||||
items = [Item(QUrl(), QUrl(), '', active=True),
|
||||
Item(QUrl(), QUrl(), ''),
|
||||
Item(QUrl(), QUrl(), '', active=True)]
|
||||
with pytest.raises(ValueError):
|
||||
tabhistory.serialize(items)
|
||||
|
||||
|
||||
def test_empty(empty_history):
|
||||
"""Check tabhistory.serialize with no items."""
|
||||
items = []
|
||||
stream, _data, user_data = tabhistory.serialize(items)
|
||||
qtutils.deserialize_stream(stream, empty_history)
|
||||
assert empty_history.count() == 0
|
||||
assert empty_history.currentItemIndex() == 0
|
||||
assert not user_data
|
||||
|
||||
Loading…
Reference in New Issue
Block a user