From 26bf588fadf40d8e51f7f010d810b8a8856b7ef3 Mon Sep 17 00:00:00 2001 From: Florian Bruhin Date: Tue, 13 Jun 2017 13:52:06 +0200 Subject: [PATCH] Fix _validate_valid_values --- qutebrowser/config/configtypes.py | 6 ------ 1 file changed, 6 deletions(-) diff --git a/qutebrowser/config/configtypes.py b/qutebrowser/config/configtypes.py index 1fc156a40..ff7a64807 100644 --- a/qutebrowser/config/configtypes.py +++ b/qutebrowser/config/configtypes.py @@ -141,17 +141,11 @@ class BaseType: Args: value: The value to validate. """ - # FIXME:conf still needed? - if not value: - return if self.valid_values is not None: if value not in self.valid_values: raise configexc.ValidationError( value, "valid values: {}".format(', '.join(self.valid_values))) - else: - raise NotImplementedError("{} does not implement validate.".format( - self.__class__.__name__)) def from_str(self, value): """Get the setting value from a string.