From 26124920cdc10cad671e8d0e59916d50b0bd3c3c Mon Sep 17 00:00:00 2001 From: Florian Bruhin Date: Tue, 22 Apr 2014 14:06:32 +0200 Subject: [PATCH] Display warnings if at beginning/end of history --- qutebrowser/browser/curcommand.py | 14 ++++++++++---- 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/qutebrowser/browser/curcommand.py b/qutebrowser/browser/curcommand.py index 370b412bd..1af7ba776 100644 --- a/qutebrowser/browser/curcommand.py +++ b/qutebrowser/browser/curcommand.py @@ -160,9 +160,12 @@ class CurCommandDispatcher(QObject): Args: count: How many pages to go back. """ - # FIXME display warning if beginning of history for _ in range(count): - self._tabs.currentWidget().back() + if self._tabs.currentWidget().page_.history().canGoBack(): + self._tabs.currentWidget().back() + else: + message.info("At beginning of history.") + break @cmdutils.register(instance='mainwindow.tabs.cur') def forward(self, count=1): @@ -173,9 +176,12 @@ class CurCommandDispatcher(QObject): Args: count: How many pages to go forward. """ - # FIXME display warning if end of history for _ in range(count): - self._tabs.currentWidget().forward() + if self._tabs.currentWidget().page_.history().canGoForward(): + self._tabs.currentWidget().forward() + else: + message.info("At end of history.") + break @cmdutils.register(instance='mainwindow.tabs.cur') def hint(self, mode="all", target="normal"):