From 25baf3b97e1bad7355cc0f4bd85ce4053df84ba4 Mon Sep 17 00:00:00 2001
From: Florian Bruhin <git@the-compiler.org>
Date: Fri, 15 Sep 2017 12:04:57 +0200
Subject: [PATCH] Add more tests for config.py error handling

---
 tests/unit/config/test_configfiles.py | 89 ++++++++++++++++++++++++++-
 1 file changed, 88 insertions(+), 1 deletion(-)

diff --git a/tests/unit/config/test_configfiles.py b/tests/unit/config/test_configfiles.py
index c598f4acb..d18218fd0 100644
--- a/tests/unit/config/test_configfiles.py
+++ b/tests/unit/config/test_configfiles.py
@@ -22,7 +22,7 @@ import sys
 
 import pytest
 
-from qutebrowser.config import config, configfiles
+from qutebrowser.config import config, configfiles, configexc
 from qutebrowser.utils import objreg
 
 from PyQt5.QtCore import QSettings
@@ -176,6 +176,93 @@ class TestConfigPy:
         assert not (config_tmpdir / 'config.py').exists()
         configfiles.read_config_py()  # Should not crash
 
+    def test_oserror(self, tmpdir):
+        with pytest.raises(configexc.ConfigFileErrors) as excinfo:
+            configfiles.read_config_py(tmpdir / 'foo')
+
+        assert len(excinfo.value.errors) == 1
+        error = excinfo.value.errors[0]
+        assert isinstance(error.exception, OSError)
+        assert error.text == "Error while reading foo"
+        assert error.traceback is None
+
+    def test_nul_bytes(self, confpy):
+        confpy.write('\0')
+        with pytest.raises(configexc.ConfigFileErrors) as excinfo:
+            configfiles.read_config_py(confpy.filename)
+
+        assert len(excinfo.value.errors) == 1
+        error = excinfo.value.errors[0]
+        assert isinstance(error.exception, ValueError)
+        assert error.text == "Error while compiling"
+        exception_text = 'source code string cannot contain null bytes'
+        assert str(error.exception) == exception_text
+        assert error.traceback is None
+
+    def test_syntax_error(self, confpy):
+        confpy.write('+')
+        with pytest.raises(configexc.ConfigFileErrors) as excinfo:
+            configfiles.read_config_py(confpy.filename)
+
+        assert len(excinfo.value.errors) == 1
+        error = excinfo.value.errors[0]
+        assert isinstance(error.exception, SyntaxError)
+        assert error.text == "Syntax Error"
+        exception_text = 'invalid syntax (config.py, line 1)'
+        assert str(error.exception) == exception_text
+
+        tblines = error.traceback.strip().splitlines()
+        assert tblines[0] == "Traceback (most recent call last):"
+        assert tblines[-1] == "SyntaxError: invalid syntax"
+        assert "    +" in tblines
+        assert "    ^" in tblines
+
+    def test_unhandled_exception(self, confpy):
+        confpy.write("config.load_autoconfig = False", "1/0")
+        api = configfiles.read_config_py(confpy.filename)
+
+        assert not api.load_autoconfig
+
+        assert len(api.errors) == 1
+        error = api.errors[0]
+        assert error.text == "Unhandled exception"
+        assert isinstance(error.exception, ZeroDivisionError)
+
+        tblines = error.traceback.strip().splitlines()
+        assert tblines[0] == "Traceback (most recent call last):"
+        assert tblines[-1] == "ZeroDivisionError: division by zero"
+        assert "    1/0" in tblines
+
+    @pytest.mark.parametrize('line', ["c.foo = 42", "config.set('foo', 42)"])
+    def test_config_error(self, confpy, line):
+        confpy.write(line, "config.load_autoconfig = False")
+        api = configfiles.read_config_py(confpy.filename)
+
+        assert not api.load_autoconfig
+
+        assert len(api.errors) == 1
+        error = api.errors[0]
+        assert error.text == "While setting 'foo'"
+        assert isinstance(error.exception, configexc.NoOptionError)
+        assert str(error.exception) == "No option 'foo'"
+        assert error.traceback is None
+
+    def test_multiple_errors(self, confpy):
+        confpy.write("c.foo = 42", "config.set('foo', 42)", "1/0")
+        api = configfiles.read_config_py(confpy.filename)
+        assert len(api.errors) == 3
+
+        for error in api.errors[:2]:
+            assert error.text == "While setting 'foo'"
+            assert isinstance(error.exception, configexc.NoOptionError)
+            assert str(error.exception) == "No option 'foo'"
+            assert error.traceback is None
+
+        error = api.errors[2]
+        assert error.text == "Unhandled exception"
+        assert isinstance(error.exception, ZeroDivisionError)
+        assert error.traceback is not None
+
 
 @pytest.fixture
 def init_patch(qapp, fake_save_manager, config_tmpdir, data_tmpdir,