From e250d42f0b2fee2041760356eeedd760421172da Mon Sep 17 00:00:00 2001 From: Florian Bruhin Date: Wed, 16 Jul 2014 09:28:28 +0200 Subject: [PATCH 1/2] Better debugging for editing --- qutebrowser/browser/commands.py | 4 ++++ qutebrowser/utils/webelem.py | 7 ++++++- 2 files changed, 10 insertions(+), 1 deletion(-) diff --git a/qutebrowser/browser/commands.py b/qutebrowser/browser/commands.py index 952e35d4e..b856b7717 100644 --- a/qutebrowser/browser/commands.py +++ b/qutebrowser/browser/commands.py @@ -737,7 +737,11 @@ class CommandDispatcher: if elem.isNull(): raise CommandError("Element vanished while editing!") if webelem.is_content_editable(elem): + log.misc.debug("Filling element {} via setPlainText.".format( + webelem.debug_text(elem))) elem.setPlainText(text) else: + log.misc.debug("Filling element {} via javascript.".format( + webelem.debug_text(elem))) text = webelem.javascript_escape(text) elem.evaluateJavaScript("this.value='{}'".format(text)) diff --git a/qutebrowser/utils/webelem.py b/qutebrowser/utils/webelem.py index ffe10885d..15163b7de 100644 --- a/qutebrowser/utils/webelem.py +++ b/qutebrowser/utils/webelem.py @@ -249,7 +249,7 @@ def is_editable(elem, strict=False): # pylint: disable=too-many-return-statements roles = ('combobox', 'textbox') log.misc.debug("Checking if element is editable: {}".format( - compact_text(elem.toOuterXml(), 500))) + debug_text(elem))) tag = elem.tagName().lower() if is_content_editable(elem) and is_writable(elem): return True @@ -279,3 +279,8 @@ def focus_elem(frame): frame: The QWebFrame to search in. """ return frame.findFirstElement(SELECTORS[Group.focus]) + + +def debug_text(elem): + """Get a text based on an element suitable for debug output.""" + return compact_text(elem.toOuterXml(), 500) From d8f0d0811d29b2bf70dbd3c2356bfc1f4fa85499 Mon Sep 17 00:00:00 2001 From: Florian Bruhin Date: Wed, 16 Jul 2014 09:28:52 +0200 Subject: [PATCH 2/2] Update BUGS --- doc/BUGS | 2 ++ 1 file changed, 2 insertions(+) diff --git a/doc/BUGS b/doc/BUGS index e9756674b..ba31e0ee9 100644 --- a/doc/BUGS +++ b/doc/BUGS @@ -101,6 +101,8 @@ Bugs window has a bigger size hint instead of tabs getting smaller than the minimum size (iggy) +- Opening editor is broken on http://p.cmpl.cc/ + - Segfault on subsonic when clicking next track - Assertion failure on subsonic with debug build