rnhmjoj/qutebrowser
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Add a -d/--detach argument to :spawn.

Browse Source
This commit is contained in:
Florian Bruhin 2015-05-31 16:25:25 +02:00
parent 17bb9fc21c
commit 231f1d90ce
1 changed files with 9 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
qutebrowser/browser/commands.py
View File

@ -922,7 +922,8 @@ class CommandDispatcher:
@cmdutils.register(instance='command-dispatcher', scope='window', @cmdutils.register(instance='command-dispatcher', scope='window',
win_id='win_id') win_id='win_id')
def spawn(self, win_id, userscript=False, quiet=False, *args): def spawn(self, win_id, userscript=False, quiet=False, detach=False,
*args):
"""Spawn a command in a shell. """Spawn a command in a shell.
Note the {url} variable which gets replaced by the current URL might be Note the {url} variable which gets replaced by the current URL might be
@ -931,6 +932,7 @@ class CommandDispatcher:
Args: Args:
userscript: Run the command as an userscript. userscript: Run the command as an userscript.
quiet: Don't print the commandline being executed. quiet: Don't print the commandline being executed.
detach: Whether the command should be detached from qutebrowser.
*args: The commandline to execute. *args: The commandline to execute.
""" """
log.procs.debug("Executing: {}, userscript={}".format( log.procs.debug("Executing: {}, userscript={}".format(
@ -944,7 +946,12 @@ class CommandDispatcher:
else: else:
proc = QProcess(self._tabbed_browser) proc = QProcess(self._tabbed_browser)
proc.error.connect(self.on_process_error) proc.error.connect(self.on_process_error)
proc.start(cmd, args) if detach:
ok = proc.startDetached(cmd, args)
if not ok:
raise cmdexc.CommandError("Error while spawning command")
else:
proc.start(cmd, args)
@pyqtSlot('QProcess::ProcessError') @pyqtSlot('QProcess::ProcessError')
def on_process_error(self, error): def on_process_error(self, error):