From 8c487e9a5f12a1e3360ec6d205104659c1e86833 Mon Sep 17 00:00:00 2001 From: Nick Ginther Date: Tue, 24 May 2016 15:18:22 -0500 Subject: [PATCH 1/3] fix tabindex statusbar not updating (#1247) --- qutebrowser/mainwindow/tabbedbrowser.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/qutebrowser/mainwindow/tabbedbrowser.py b/qutebrowser/mainwindow/tabbedbrowser.py index b754ce9cb..708ba8174 100644 --- a/qutebrowser/mainwindow/tabbedbrowser.py +++ b/qutebrowser/mainwindow/tabbedbrowser.py @@ -412,6 +412,8 @@ class TabbedBrowser(tabwidget.TabWidget): background = config.get('tabs', 'background-tabs') if not background: self.setCurrentWidget(tab) + elif background: + self.tab_index_changed.emit(self.currentIndex(), self.count()) tab.show() self.new_tab.emit(tab, idx) return tab From c70accda229b2c8dd67abb29e0f14cfdf5c1c59a Mon Sep 17 00:00:00 2001 From: Nick Ginther Date: Wed, 25 May 2016 13:46:31 -0500 Subject: [PATCH 2/3] restructure code --- qutebrowser/mainwindow/tabbedbrowser.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/qutebrowser/mainwindow/tabbedbrowser.py b/qutebrowser/mainwindow/tabbedbrowser.py index 708ba8174..701397877 100644 --- a/qutebrowser/mainwindow/tabbedbrowser.py +++ b/qutebrowser/mainwindow/tabbedbrowser.py @@ -410,10 +410,10 @@ class TabbedBrowser(tabwidget.TabWidget): tab.openurl(url) if background is None: background = config.get('tabs', 'background-tabs') - if not background: - self.setCurrentWidget(tab) - elif background: + if background: self.tab_index_changed.emit(self.currentIndex(), self.count()) + else: + self.setCurrentWidget(tab) tab.show() self.new_tab.emit(tab, idx) return tab From 4c0f85564d8c4ccb8a30289ace9864e6c1be20bc Mon Sep 17 00:00:00 2001 From: Florian Bruhin Date: Wed, 25 May 2016 22:09:48 +0200 Subject: [PATCH 3/3] Update docs --- CHANGELOG.asciidoc | 1 + README.asciidoc | 1 + 2 files changed, 2 insertions(+) diff --git a/CHANGELOG.asciidoc b/CHANGELOG.asciidoc index cdb94d15c..cf9195b08 100644 --- a/CHANGELOG.asciidoc +++ b/CHANGELOG.asciidoc @@ -63,6 +63,7 @@ Fixed - Fixed crash when using `;Y` (`:hint links yank-primary`) on a system without primary selection - Don't display quit confirmation with finished downloads +- Fixed updating the tab index in the statusbar when opening a background tab v0.6.2 ------ diff --git a/README.asciidoc b/README.asciidoc index c4cf56252..95b6b8271 100644 --- a/README.asciidoc +++ b/README.asciidoc @@ -194,6 +194,7 @@ Contributors, sorted by the number of commits in descending order: * Ismail * Samir Benmendil * Regina Hug +* Nick Ginther * Mathias Fussenegger * Marcelo Santos * Jan Verbeek