rnhmjoj/qutebrowser
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Assert if index is invalid in delete_cur_item.

Browse Source 
CompletionView already checks the index, so an error here shouldn't
happen.
This commit is contained in:
Ryan Roden-Corrent 2017-06-29 20:58:15 -04:00
parent fd07c571e5
commit 1e489325c4
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
qutebrowser/completion/models/completionmodel.py
View File

@ -215,10 +215,10 @@ class CompletionModel(QAbstractItemModel):
def delete_cur_item(self, index): def delete_cur_item(self, index):
"""Delete the row at the given index.""" """Delete the row at the given index."""
qtutils.ensure_valid(index)
parent = index.parent() parent = index.parent()
cat = self._cat_from_idx(parent) cat = self._cat_from_idx(parent)
if not cat: assert cat, "CompletionView sent invalid index for deletion"
raise cmdexc.CommandError("No category selected")
self.beginRemoveRows(parent, index.row(), index.row()) self.beginRemoveRows(parent, index.row(), index.row())
cat.delete_cur_item(cat.index(index.row(), 0)) cat.delete_cur_item(cat.index(index.row(), 0))
self.endRemoveRows() self.endRemoveRows()