rnhmjoj/qutebrowser
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

bdd: Make "I wait for a prompt" step explicit.

Browse Source
This commit is contained in:
Florian Bruhin 2016-01-13 23:18:51 +01:00
parent abcb366c12
commit 1d63e2dff4
2 changed files with 8 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
tests/integration/features/prompts.feature
View File

@ -9,32 +9,34 @@ Feature: Prompts
Scenario: Javascript alert Scenario: Javascript alert
When I open data/prompt/jsalert.html When I open data/prompt/jsalert.html
And I click the button And I click the button
And I wait for a prompt
And I run :prompt-accept And I run :prompt-accept
Then the javascript message "Alert done" should be logged Then the javascript message "Alert done" should be logged
Scenario: Using content -> ignore-javascript-alert Scenario: Using content -> ignore-javascript-alert
When I set content -> ignore-javascript-alert to true When I set content -> ignore-javascript-alert to true
And I open data/prompt/jsalert.html And I open data/prompt/jsalert.html
# Can't use "I click the button" as it waits for a key mode change And I click the button
And I run :hint
And I run :follow-hint a
Then the javascript message "Alert done" should be logged Then the javascript message "Alert done" should be logged
Scenario: Javascript confirm - yes Scenario: Javascript confirm - yes
When I open data/prompt/jsconfirm.html When I open data/prompt/jsconfirm.html
And I click the button And I click the button
And I wait for a prompt
And I run :prompt-yes And I run :prompt-yes
Then the javascript message "confirm reply: true" should be logged Then the javascript message "confirm reply: true" should be logged
Scenario: Javascript confirm - no Scenario: Javascript confirm - no
When I open data/prompt/jsconfirm.html When I open data/prompt/jsconfirm.html
And I click the button And I click the button
And I wait for a prompt
And I run :prompt-no And I run :prompt-no
Then the javascript message "confirm reply: false" should be logged Then the javascript message "confirm reply: false" should be logged
Scenario: Javascript confirm - aborted Scenario: Javascript confirm - aborted
When I open data/prompt/jsconfirm.html When I open data/prompt/jsconfirm.html
And I click the button And I click the button
And I wait for a prompt
And I run :leave-mode And I run :leave-mode
Then the javascript message "confirm reply: false" should be logged Then the javascript message "confirm reply: false" should be logged
@ -42,6 +44,7 @@ Feature: Prompts
Scenario: Javascript prompt Scenario: Javascript prompt
When I open data/prompt/jsprompt.html When I open data/prompt/jsprompt.html
And I click the button And I click the button
And I wait for a prompt
And I press the keys "prompt test" And I press the keys "prompt test"
And I run :prompt-accept And I run :prompt-accept
Then the javascript message "Prompt reply: prompt test" should be logged Then the javascript message "Prompt reply: prompt test" should be logged
@ -50,6 +53,7 @@ Feature: Prompts
Scenario: Rejected javascript prompt Scenario: Rejected javascript prompt
When I open data/prompt/jsprompt.html When I open data/prompt/jsprompt.html
And I click the button And I click the button
And I wait for a prompt
And I press the keys "prompt test" And I press the keys "prompt test"
And I run :leave-mode And I run :leave-mode
Then the javascript message "Prompt reply: null" should be logged Then the javascript message "Prompt reply: null" should be logged
@ -58,9 +62,7 @@ Feature: Prompts
Scenario: Using content -> ignore-javascript-prompt Scenario: Using content -> ignore-javascript-prompt
When I set content -> ignore-javascript-prompt to true When I set content -> ignore-javascript-prompt to true
And I open data/prompt/jsprompt.html And I open data/prompt/jsprompt.html
# Can't use "I click the button" as it waits for a key mode change And I click the button
And I run :hint
And I run :follow-hint a
Then the javascript message "Prompt reply: null" should be logged Then the javascript message "Prompt reply: null" should be logged
# SSL # SSL

1
tests/integration/features/test_prompts.py
View File

@ -37,7 +37,6 @@ def wait_ssl_page_finished_loading(quteproc, ssl_server):
def click_button(quteproc): def click_button(quteproc):
quteproc.send_cmd(':hint') quteproc.send_cmd(':hint')
quteproc.send_cmd(':follow-hint a') quteproc.send_cmd(':follow-hint a')
wait_for_prompt(quteproc)
@bdd.when("I wait for a prompt") @bdd.when("I wait for a prompt")