rnhmjoj/qutebrowser
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Simplify get_qt_args

Browse Source
This commit is contained in:
Florian Bruhin 2014-06-12 15:13:26 +02:00
parent 7628c92689
commit 1b8a44ac26
2 changed files with 5 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
qutebrowser/test/utils/test_misc.py
View File

@ -430,11 +430,6 @@ class GetQtArgsTests(TestCase):
'-stylesheet', 'foobar', '-stylesheet', 'foobar',
'-reverse']) '-reverse'])
def test_qt_unknown(self):
"""Test commandline with unknown Qt argument."""
ns = self._namespace(['--qt-foo'], flags=['--qt-foo'])
self.assertEqual(utils.get_qt_args(ns), [sys.argv[0]])
if __name__ == '__main__': if __name__ == '__main__':
unittest.main() unittest.main()

11
qutebrowser/utils/misc.py
View File

@ -272,16 +272,15 @@ def get_qt_args(namespace):
The argv list to be passed to Qt. The argv list to be passed to Qt.
""" """
argv = [sys.argv[0]] argv = [sys.argv[0]]
qt_args = ('style', 'stylesheet', 'widget-count', 'reverse', for argname, val in vars(namespace).items():
'qmljsdebugger') if not argname.startswith('qt_'):
for argname in qt_args: pass
val = getattr(namespace, 'qt_' + argname, None)
if val is None: if val is None:
# flag/argument not given # flag/argument not given
continue continue
elif val is True: elif val is True:
argv.append('-' + argname) argv.append('-' + argname[3:])
else: else:
argv.append('-' + argname) argv.append('-' + argname[3:])
argv.append(val[0]) argv.append(val[0])
return argv return argv