From 1b0a125cf3863f19bf98912b0eb851e0f22cdcdc Mon Sep 17 00:00:00 2001 From: Florian Bruhin Date: Tue, 6 Jun 2017 15:54:13 +0200 Subject: [PATCH] websettings: Improve errors when setting settings=... --- qutebrowser/browser/webengine/webenginesettings.py | 8 ++++++-- qutebrowser/config/websettings.py | 2 +- 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/qutebrowser/browser/webengine/webenginesettings.py b/qutebrowser/browser/webengine/webenginesettings.py index 49a821d30..a468e1294 100644 --- a/qutebrowser/browser/webengine/webenginesettings.py +++ b/qutebrowser/browser/webengine/webenginesettings.py @@ -102,7 +102,9 @@ class DefaultProfileSetter(websettings.Base): return utils.get_repr(self, setter=self._setter, constructor=True) def _set(self, value, settings=None): - utils.unused(settings) + if settings is not None: + raise ValueError("'settings' may not be set with " + "DefaultProfileSetters!") setter = getattr(default_profile, self._setter) setter(value) @@ -119,7 +121,9 @@ class PersistentCookiePolicy(DefaultProfileSetter): return config.get('content', 'cookies-store') def _set(self, value, settings=None): - utils.unused(settings) + if settings is not None: + raise ValueError("'settings' may not be set with " + "PersistentCookiePolicy!") setter = getattr(QWebEngineProfile.defaultProfile(), self._setter) setter( QWebEngineProfile.AllowPersistentCookies if value else diff --git a/qutebrowser/config/websettings.py b/qutebrowser/config/websettings.py index 28f9954a6..d2ab52ccc 100644 --- a/qutebrowser/config/websettings.py +++ b/qutebrowser/config/websettings.py @@ -163,7 +163,7 @@ class StaticSetter(Setter): def _set(self, value, settings=None): if settings is not None: - raise ValueError("'settings' may not be set with GlobalSetters!") + raise ValueError("'settings' may not be set with StaticSetters!") args = list(self._args) if self._unpack: args.extend(value)