From 1a9bc64776bfcd0a0b49ce4b7fa0fe4cee8498f5 Mon Sep 17 00:00:00 2001 From: Florian Bruhin Date: Sun, 31 May 2015 16:32:21 +0200 Subject: [PATCH] Display an error on non-zero :spawn exit. --- qutebrowser/browser/commands.py | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/qutebrowser/browser/commands.py b/qutebrowser/browser/commands.py index 2c4816e33..1aed25ce4 100644 --- a/qutebrowser/browser/commands.py +++ b/qutebrowser/browser/commands.py @@ -952,6 +952,8 @@ class CommandDispatcher: raise cmdexc.CommandError("Error while spawning command") else: proc.start(cmd, args) + if not quiet: + proc.finished.connect(self.on_process_finished) @pyqtSlot('QProcess::ProcessError') def on_process_error(self, error): @@ -961,6 +963,13 @@ class CommandDispatcher: "Error while spawning command: {}".format(msg), immediately=True) + @pyqtSlot(int, 'QProcess::ExitStatus') + def on_process_finished(self, code, _status): + """Display an error if a :spawn'ed process exited with non-0 status.""" + if code != 0: + message.error(self._win_id, "Spawned command exited with status " + "{}!".format(code)) + @cmdutils.register(instance='command-dispatcher', scope='window') def home(self): """Open main startpage in current tab."""