From 19c00ff92af64e7da97dce46439a86509c6f065d Mon Sep 17 00:00:00 2001 From: Florian Bruhin Date: Tue, 20 Feb 2018 07:11:23 +0100 Subject: [PATCH] configutils: Clean up comments --- qutebrowser/config/configutils.py | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/qutebrowser/config/configutils.py b/qutebrowser/config/configutils.py index 05bebf286..0d324bb47 100644 --- a/qutebrowser/config/configutils.py +++ b/qutebrowser/config/configutils.py @@ -114,8 +114,11 @@ class Values: self._values.append(scoped) def remove(self, pattern=None): - """Remove the value with the given pattern.""" - # FIXME:conf Should this ignore patterns which weren't found? + """Remove the value with the given pattern. + + If a matching pattern was removed, True is returned. + If no matching pattern was found, False is returned. + """ old_len = len(self._values) self._values = [v for v in self._values if v.pattern != pattern] return old_len != len(self._values) @@ -128,8 +131,6 @@ class Values: """Get the fallback global/default value.""" for scoped in self._values: if scoped.pattern is None: - # It's possible that the setting is only customized from the - # default for a given URL. return scoped.value if fallback: