rnhmjoj/qutebrowser
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

proxy_from_url: fix PACFetcher construction

Browse Source
This commit is contained in:
Nikolay Amiantov 2017-01-02 18:49:14 +03:00
parent ea2eefccb1
commit 19966a9b9f
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
qutebrowser/utils/urlutils.py
View File

@ -614,7 +614,7 @@ def proxy_from_url(url):
scheme = url.scheme() scheme = url.scheme()
if scheme in ['pac+http', 'pac+https']: if scheme in ['pac+http', 'pac+https']:
return pac.PACFetcher return pac.PACFetcher(url)
types = { types = {
'http': QNetworkProxy.HttpProxy, 'http': QNetworkProxy.HttpProxy,

2
tests/unit/utils/test_urlutils.py
View File

@ -765,7 +765,7 @@ class TestProxyFromUrl:
@pytest.mark.parametrize('scheme', ['pac+http', 'pac+https']) @pytest.mark.parametrize('scheme', ['pac+http', 'pac+https'])
def test_proxy_from_url_pac(self, scheme): def test_proxy_from_url_pac(self, scheme):
fetcher = urlutils.proxy_from_url(QUrl('{}://foo'.format(scheme))) fetcher = urlutils.proxy_from_url(QUrl('{}://foo'.format(scheme)))
assert fetcher is pac.PACFetcher assert isinstance(fetcher, pac.PACFetcher)
@pytest.mark.parametrize('url, exception', [ @pytest.mark.parametrize('url, exception', [
('blah', urlutils.InvalidProxyTypeError), ('blah', urlutils.InvalidProxyTypeError),