From 1899e313fd4f0a35cb71390053ebbcb8df451537 Mon Sep 17 00:00:00 2001 From: Florian Bruhin Date: Thu, 8 Mar 2018 08:14:52 +0100 Subject: [PATCH] Disallow binding to an empty command This was introduced (most likely accidentally) in 9cbacf3264fdfcbf491a48811de151779f0ebebc. Fixes #3631 --- doc/changelog.asciidoc | 1 + qutebrowser/config/configdata.yml | 4 +--- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/doc/changelog.asciidoc b/doc/changelog.asciidoc index e0c891a13..0d6adc5b6 100644 --- a/doc/changelog.asciidoc +++ b/doc/changelog.asciidoc @@ -134,6 +134,7 @@ Fixed - HTML/JS resource files are now read into RAM on start to avoid crashes when changing qutebrowser versions while it's open. - Setting `bindings.key_mappings` to an empty value is now allowed. +- Binding to an empty command now shows an error rather than crashing. Removed ~~~~~~~ diff --git a/qutebrowser/config/configdata.yml b/qutebrowser/config/configdata.yml index c5d06bf1d..a778d1d35 100644 --- a/qutebrowser/config/configdata.yml +++ b/qutebrowser/config/configdata.yml @@ -2485,9 +2485,7 @@ bindings.commands: name: Dict none_ok: true keytype: Key - valtype: - name: Command - none_ok: true + valtype: Command desc: >- Keybindings mapping keys to commands in different modes.