rnhmjoj/qutebrowser
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

editor test cleanup

Browse Source
This commit is contained in:
Florian Bruhin 2014-05-27 11:17:14 +02:00
parent 156d63b4b6
commit 15f8a3e6dd
1 changed files with 5 additions and 19 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
qutebrowser/test/utils/test_editor.py
View File

@ -45,9 +45,6 @@ class ConfigStub:
class FakeQProcess: class FakeQProcess:
finished = Mock()
error = Mock()
NormalExit = QProcess.NormalExit NormalExit = QProcess.NormalExit
CrashExit = QProcess.CrashExit CrashExit = QProcess.CrashExit
@ -58,17 +55,10 @@ class FakeQProcess:
ReadError = QProcess.ReadError ReadError = QProcess.ReadError
UnknownError = QProcess.UnknownError UnknownError = QProcess.UnknownError
def __init__(self, parent): def __init__(self, parent=None):
self.executable = None self.finished = Mock()
self.args = None self.error = Mock()
self.start = Mock()
def start(self, executable, args):
self.executable = executable
self.args = args
self.on_started()
def on_started(self):
pass
def setUpModule(): def setUpModule():
@ -84,7 +74,7 @@ class FileHandlingTests(TestCase):
def setUp(self): def setUp(self):
self.editor = editor.ExternalEditor() self.editor = editor.ExternalEditor()
self.editor.editing_finished = Mock() self.editor.editing_finished = Mock()
editor.config = ConfigStub([""]) editor.config = ConfigStub(editor=[""])
def test_file_handling_closed_ok(self): def test_file_handling_closed_ok(self):
"""Test file handling when closing with an exitstatus == 0.""" """Test file handling when closing with an exitstatus == 0."""
@ -112,9 +102,5 @@ class FileHandlingTests(TestCase):
self.assertFalse(os.path.exists(filename)) self.assertFalse(os.path.exists(filename))
#self.editor.proc.start.assert_called_with("")
#self.assertTrue(self.editor.proc.
if __name__ == '__main__': if __name__ == '__main__':
unittest.main() unittest.main()