rnhmjoj/qutebrowser
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

PAC: fix isPlainHostName()

Browse Source 
Fix isPlainHostName() implementation and add test-case for it.

Signed-off-by: Kirill A. Shutemov <kirill@shutemov.name>
This commit is contained in:
Kirill A. Shutemov 2017-02-21 02:05:54 +03:00
parent 1708b38d7b
commit 13213724b0
2 changed files with 10 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
qutebrowser/javascript/pac_utils.js
View File

@ -78,7 +78,7 @@ function isInNet(ipaddr, pattern, maskstr) {
} }
function isPlainHostName(host) { function isPlainHostName(host) {
return (host.search('\\\\.') == -1); return (host.search('\\.') == -1);
} }
function isResolvable(host) { function isResolvable(host) {

9
tests/unit/browser/webkit/network/test_pac.py
View File

@ -109,6 +109,15 @@ def test_myIpAddress():
_pac_equality_test("isResolvable(myIpAddress())", "true") _pac_equality_test("isResolvable(myIpAddress())", "true")
@pytest.mark.parametrize("host, expected", [
("example", "true"),
("example.com", "false"),
("www.example.com", "false"),
])
def test_isPlainHostName(host, expected):
_pac_equality_test("isPlainHostName('{}')".format(host), expected)
def test_proxyBindings(): def test_proxyBindings():
_pac_equality_test("JSON.stringify(ProxyConfig.bindings)", "'{}'") _pac_equality_test("JSON.stringify(ProxyConfig.bindings)", "'{}'")