rnhmjoj/qutebrowser
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Add validation for search engine URLs and colors

Browse Source
This commit is contained in:
Florian Bruhin 2014-04-17 17:59:57 +02:00
parent 39f580d9f1
commit 1282a211cf
1 changed files with 20 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
qutebrowser/config/conftypes.py
View File

@ -17,6 +17,8 @@
"""Setting options used for qutebrowser.""" """Setting options used for qutebrowser."""
from PyQt5.QtGui import QColor
class ValidationError(ValueError): class ValidationError(ValueError):
@ -281,13 +283,24 @@ class Command(BaseType):
class Color(BaseType): class Color(BaseType):
"""Base class for a color value.""" """Base class for a color value.
Class attributes:
_GRADIENTS: Valid gradient function names.
"""
typestr = 'color' typestr = 'color'
_GRADIENTS = ['qlineargradient', 'qradialgradient', 'qconicalgradient']
def validate(self, value): def validate(self, value):
# FIXME validate colors if any([value.startswith(start) for start in Color._GRADIENTS]):
# We can't validate this further.
return
if QColor.isValidColor(value):
pass pass
else:
raise ValidationError(value, "must be a valid color")
class Font(BaseType): class Font(BaseType):
@ -314,7 +327,10 @@ class SearchEngineUrl(BaseType):
"""A search engine URL.""" """A search engine URL."""
def validate(self, value): def validate(self, value):
return "{}" in value if "{}" in value:
pass
else:
raise ValidationError(value, 'must contain "{}"')
class KeyBindingName(BaseType): class KeyBindingName(BaseType):