From 11abb642abb26acdf47370dc5a3e3445d56b28da Mon Sep 17 00:00:00 2001 From: Florian Bruhin Date: Mon, 12 Sep 2016 20:53:01 +0200 Subject: [PATCH] Remove downloading test with deleting handler This actually is kind of tricky, and it makes later tests fail because the tmpdir is suddenly gone... --- tests/end2end/features/downloads.feature | 10 ---------- tests/end2end/features/test_downloads_bdd.py | 8 -------- 2 files changed, 18 deletions(-) diff --git a/tests/end2end/features/downloads.feature b/tests/end2end/features/downloads.feature index d42d4aeca..a59169372 100644 --- a/tests/end2end/features/downloads.feature +++ b/tests/end2end/features/downloads.feature @@ -323,16 +323,6 @@ Feature: Downloading things from a website. And I wait until the download is finished Then "Opening *download.bin* with [*python*]" should be logged - Scenario: Opening a download with a handler which deletes the tmpdir - When I set storage -> prompt-download-directory to true - And I open data/downloads/download.bin - And I directly open the download with a handler deleting the tmpdir - And I wait until the download is finished - And I run :quit - Then "Opening *download.bin* with [*python*]" should be logged - And "Failed to clean up temporary download directory" should be logged - And qutebrowser should quit - # https://github.com/The-Compiler/qutebrowser/issues/1728 Scenario: Cancelling a download that should be opened diff --git a/tests/end2end/features/test_downloads_bdd.py b/tests/end2end/features/test_downloads_bdd.py index 319818876..3ce6790bb 100644 --- a/tests/end2end/features/test_downloads_bdd.py +++ b/tests/end2end/features/test_downloads_bdd.py @@ -126,14 +126,6 @@ def download_open_with_prompt(quteproc): quteproc.send_cmd(':prompt-open-download {}'.format(cmd)) -@bdd.when("I directly open the download with a handler deleting the tmpdir") -def download_open_with_prompt_deleting(quteproc): - cmd = ('{} -c "import sys, shutil, os.path; ' - 'shutil.rmtree(os.path.dirname(sys.argv[1]))"'.format( - shlex.quote(sys.executable))) - quteproc.send_cmd(':prompt-open-download {}'.format(cmd)) - - @bdd.when(bdd.parsers.parse("I delete the downloaded file {filename}")) def delete_file(tmpdir, filename): (tmpdir / filename).remove()