rnhmjoj/qutebrowser
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

completion: get rid of model-specific sort method (see #545)

Browse Source
This commit is contained in:
Jakub Klinkovský 2016-07-17 12:46:51 +02:00
parent 49327dfcbb
commit 119f9c0e18
2 changed files with 1 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
qutebrowser/completion/models/base.py
View File

@ -126,10 +126,3 @@ class BaseCompletionModel(QStandardItemModel):
else: else:
# category # category
return Qt.NoItemFlags return Qt.NoItemFlags
def sort(self, column, order=Qt.AscendingOrder):
"""Sort the data in column according to order.
Override QAbstractItemModel::sort.
"""
raise NotImplementedError

6
qutebrowser/completion/models/sortfilter.py
View File

@ -63,9 +63,6 @@ class CompletionFilterModel(QSortFilterProxyModel):
Invalidates the filter and re-sorts the model. Invalidates the filter and re-sorts the model.
If the current completion model overrides sort(), it is used.
If not, the default implementation in QCompletionFilterModel is called.
Args: Args:
val: The value to set. val: The value to set.
""" """
@ -76,9 +73,6 @@ class CompletionFilterModel(QSortFilterProxyModel):
self.pattern_re = re.compile(val, re.IGNORECASE) self.pattern_re = re.compile(val, re.IGNORECASE)
self.invalidateFilter() self.invalidateFilter()
sortcol = 0 sortcol = 0
try:
self.srcmodel.sort(sortcol)
except NotImplementedError:
self.sort(sortcol) self.sort(sortcol)
self.invalidate() self.invalidate()