rnhmjoj/qutebrowser
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Fix filtering of all hints in number mode

Browse Source 
Fixes #1559
This commit is contained in:
Florian Bruhin 2016-06-07 18:34:46 +02:00
parent 9880f5bd5f
commit 1104a731a5
2 changed files with 11 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
qutebrowser/browser/hints.py
View File

@ -897,7 +897,7 @@ class HintManager(QObject):
# Whoops, filtered all hints # Whoops, filtered all hints
modeman.leave(self._win_id, usertypes.KeyMode.hint, modeman.leave(self._win_id, usertypes.KeyMode.hint,
'all filtered') 'all filtered')
return return {}
strings = self._hint_strings(elems) strings = self._hint_strings(elems)
self._context.elems = {} self._context.elems = {}

10
tests/end2end/features/hints.feature
View File

@ -217,3 +217,13 @@ Feature: Using hints
And I run :hint all And I run :hint all
And I run :follow-hint 00 And I run :follow-hint 00
Then data/numbers/1.txt should be loaded Then data/numbers/1.txt should be loaded
# https://github.com/The-Compiler/qutebrowser/issues/1559
Scenario: Filtering all hints in number mode
When I open data/hints/number.html
And I set hints -> mode to number
And I run :hint all
And I press the key "2"
And I wait for "Leaving mode KeyMode.hint (reason: all filtered)" in the log
Then no crash should happen