rnhmjoj/qutebrowser
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Use unpacking to access config mutables

Browse Source
This commit is contained in:
Florian Bruhin 2017-09-20 08:52:11 +02:00
parent 55cbb39127
commit 10c84dfb90
1 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
qutebrowser/config/config.py
View File

@ -435,7 +435,7 @@ class Config(QObject):
# entered the mutable dictionary and thus further copies are unneeded # entered the mutable dictionary and thus further copies are unneeded
# until update_mutables() is called # until update_mutables() is called
if name in self._mutables and mutable: if name in self._mutables and mutable:
obj = self._mutables[name][1] _copy, obj = self._mutables[name]
# Otherwise, we return a copy of the value stored internally, so the # Otherwise, we return a copy of the value stored internally, so the
# internal value can never be changed by mutating the object returned. # internal value can never be changed by mutating the object returned.
else: else:
@ -487,9 +487,7 @@ class Config(QObject):
Here, we check all those saved copies for mutations, and if something Here, we check all those saved copies for mutations, and if something
mutated, we call set_obj again so we save the new value. mutated, we call set_obj again so we save the new value.
""" """
for name in self._mutables: for name, (old_value, new_value) in self._mutables.items():
old_value = self._mutables[name][0]
new_value = self._mutables[name][1]
if old_value != new_value: if old_value != new_value:
log.config.debug("{} was mutated, updating".format(name)) log.config.debug("{} was mutated, updating".format(name))
self.set_obj(name, new_value, save_yaml=save_yaml) self.set_obj(name, new_value, save_yaml=save_yaml)