From 10298e96929663c0587f8d57dbde9a72ac24605c Mon Sep 17 00:00:00 2001 From: Florian Bruhin Date: Tue, 11 Aug 2015 14:29:06 +0200 Subject: [PATCH] Don't connect destroyed signal in log_signals. This causes weird segfaults and is probably not that important to log. Fixes #867. --- qutebrowser/utils/debug.py | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/qutebrowser/utils/debug.py b/qutebrowser/utils/debug.py index 16aa53adf..e2fde62d9 100644 --- a/qutebrowser/utils/debug.py +++ b/qutebrowser/utils/debug.py @@ -68,8 +68,9 @@ def log_signals(obj): qtutils.ensure_valid(meta_method) if meta_method.methodType() == QMetaMethod.Signal: name = bytes(meta_method.name()).decode('ascii') - signal = getattr(obj, name) - signal.connect(functools.partial(log_slot, obj, signal)) + if name != 'destroyed': + signal = getattr(obj, name) + signal.connect(functools.partial(log_slot, obj, signal)) if inspect.isclass(obj): old_init = obj.__init__