From 0ebde6f2e9cdb0eb087bfea7ba225e02ec7840de Mon Sep 17 00:00:00 2001 From: Jay Kamat Date: Sun, 4 Feb 2018 02:11:34 -0500 Subject: [PATCH] Delete QWebEngineDownloadItem objects when wrapper object is deleted --- qutebrowser/browser/webengine/webenginedownloads.py | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/qutebrowser/browser/webengine/webenginedownloads.py b/qutebrowser/browser/webengine/webenginedownloads.py index d467724d5..7dec2dd54 100644 --- a/qutebrowser/browser/webengine/webenginedownloads.py +++ b/qutebrowser/browser/webengine/webenginedownloads.py @@ -45,6 +45,10 @@ class DownloadItem(downloads.AbstractDownloadItem): qt_item.downloadProgress.connect(self.stats.on_download_progress) qt_item.stateChanged.connect(self._on_state_changed) + # Ensure wrapped qt_item is deleted manually when the wrapper object + # is deleted. See https://github.com/qutebrowser/qutebrowser/issues/3373 + self.destroyed.connect(self._qt_item.deleteLater) + def _is_page_download(self): """Check if this item is a page (i.e. mhtml) download.""" return (self._qt_item.savePageFormat() !=