rnhmjoj/qutebrowser
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Only disable the cache on Qt 5.7.1

Browse Source 
I ended up bisecting it, and https://codereview.qt-project.org/#/c/153977/
causes this, which is not in 5.7.0.
This commit is contained in:
Florian Bruhin 2017-04-04 08:24:50 +02:00
parent 2eb365b146
commit 0de3b5460e
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
qutebrowser/browser/webkit/cache.py
View File

@ -54,7 +54,7 @@ class DiskCache(QNetworkDiskCache):
if size is None: if size is None:
size = 1024 * 1024 * 50 # default from QNetworkDiskCachePrivate size = 1024 * 1024 * 50 # default from QNetworkDiskCachePrivate
# WORKAROUND for https://bugreports.qt.io/browse/QTBUG-59909 # WORKAROUND for https://bugreports.qt.io/browse/QTBUG-59909
if qtutils.version_check('5.7'): # pragma: no cover if qtutils.version_check('5.7.1'): # pragma: no cover
size = 0 size = 0
self.setMaximumCacheSize(size) self.setMaximumCacheSize(size)

4
tests/unit/browser/webkit/test_cache.py
View File

@ -25,9 +25,9 @@ from qutebrowser.browser.webkit import cache
from qutebrowser.utils import qtutils from qutebrowser.utils import qtutils
pytestmark = pytest.mark.skipif(qtutils.version_check('5.7'), pytestmark = pytest.mark.skipif(qtutils.version_check('5.7.1'),
reason="QNetworkDiskCache is broken on Qt >= " reason="QNetworkDiskCache is broken on Qt >= "
"5.7") "5.7.1")
def preload_cache(cache, url='http://www.example.com/', content=b'foobar'): def preload_cache(cache, url='http://www.example.com/', content=b'foobar'):