From 0cc7f845e6c34a729a2c8776ea50f3eebc2d352a Mon Sep 17 00:00:00 2001 From: Florian Bruhin Date: Sat, 4 Feb 2017 18:10:34 +0100 Subject: [PATCH] Simplify test --- tests/unit/browser/webkit/network/test_pac.py | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/tests/unit/browser/webkit/network/test_pac.py b/tests/unit/browser/webkit/network/test_pac.py index af03c9859..c5c12b1a1 100644 --- a/tests/unit/browser/webkit/network/test_pac.py +++ b/tests/unit/browser/webkit/network/test_pac.py @@ -125,14 +125,10 @@ def test_invalid_port(): res.resolve(QNetworkProxyQuery(QUrl("https://example.com/test"))) -def test_no_function(): +@pytest.mark.parametrize(string, ["", "{"]) +def test_wrong_pac_string(string): with pytest.raises(pac.EvalProxyError): - pac.PACResolver("") - - -def test_fail_eval(): - with pytest.raises(pac.EvalProxyError): - pac.PACResolver("{") + pac.PACResolver(string) @pytest.mark.parametrize("value", [