From 0c653c4703848085f79b64b2b4c8b7360c78ab24 Mon Sep 17 00:00:00 2001 From: Florian Bruhin Date: Fri, 28 Apr 2017 14:48:08 +0200 Subject: [PATCH] Handle elem.className in webelem.js --- qutebrowser/javascript/webelem.js | 8 +++++++- tests/end2end/features/misc.feature | 6 ++++++ 2 files changed, 13 insertions(+), 1 deletion(-) diff --git a/qutebrowser/javascript/webelem.js b/qutebrowser/javascript/webelem.js index 749dfcc72..3b0e324dd 100644 --- a/qutebrowser/javascript/webelem.js +++ b/qutebrowser/javascript/webelem.js @@ -53,7 +53,6 @@ window._qutebrowser.webelem = (function() { "text": elem.text, "value": elem.value, "outer_xml": elem.outerHTML, - "class_name": elem.className, "rects": [], // Gets filled up later }; @@ -66,6 +65,13 @@ window._qutebrowser.webelem = (function() { out.tag_name = ""; } + if (typeof elem.className === "string") { + out.class_name = elem.className; + } else { + // e.g. SVG elements + out.class_name = ""; + } + var attributes = {}; for (var i = 0; i < elem.attributes.length; ++i) { var attr = elem.attributes[i]; diff --git a/tests/end2end/features/misc.feature b/tests/end2end/features/misc.feature index 171fdf476..b65939ec1 100644 --- a/tests/end2end/features/misc.feature +++ b/tests/end2end/features/misc.feature @@ -735,3 +735,9 @@ Feature: Various utility commands. And I run :click-element id theform And I wait for "Clicked editable element!" in the log Then no crash should happen + + Scenario: Clicking on svg element + When I open data/issue2569.html + And I run :click-element id icon + And I wait for "Clicked non-editable element!" in the log + Then no crash should happen