From 0c0cb48471a80538f92270511a798600bc129300 Mon Sep 17 00:00:00 2001 From: Florian Bruhin Date: Thu, 22 May 2014 15:44:16 +0200 Subject: [PATCH] Fix lint --- qutebrowser/app.py | 3 +++ qutebrowser/browser/quickmarks.py | 3 ++- qutebrowser/commands/userscripts.py | 1 + qutebrowser/utils/readline.py | 1 - 4 files changed, 6 insertions(+), 2 deletions(-) diff --git a/qutebrowser/app.py b/qutebrowser/app.py index a5b5a268b..9e5f01758 100644 --- a/qutebrowser/app.py +++ b/qutebrowser/app.py @@ -91,6 +91,7 @@ class QuteBrowser(QApplication): modeman: The global ModeManager instance. networkmanager: The global NetworkManager instance. cookiejar: The global CookieJar instance. + rl_bridge: The ReadlineBridge being used. _keyparsers: A mapping from modes to keyparsers. _args: ArgumentParser instance. _timers: List of used QTimers so they don't get GCed. @@ -118,6 +119,7 @@ class QuteBrowser(QApplication): self._keyparsers = None self._crashdlg = None self._crashlogfile = None + self.rl_bridge = None self.messagebridge = None self.stateconfig = None self.modeman = None @@ -600,6 +602,7 @@ class QuteBrowser(QApplication): For some reason lastWindowClosing sometimes seem to get emitted twice, so we make sure we only run once here. """ + # pylint: disable=too-many-branches if self._shutting_down: return self._shutting_down = True diff --git a/qutebrowser/browser/quickmarks.py b/qutebrowser/browser/quickmarks.py index 06f44c7c6..ef81726a1 100644 --- a/qutebrowser/browser/quickmarks.py +++ b/qutebrowser/browser/quickmarks.py @@ -37,7 +37,7 @@ linecp = None def init(): """Read quickmarks from the config file.""" - global marks, linecp + global linecp confdir = get_standard_dir(QStandardPaths.ConfigLocation) linecp = LineConfigParser(confdir, 'quickmarks') for line in linecp: @@ -71,6 +71,7 @@ def quickmark_add(url, name): raise CommandError("Can't set mark with empty URL!") def set_mark(): + """Really set the quickmark.""" marks[name] = urlstring(url) if name in marks: diff --git a/qutebrowser/commands/userscripts.py b/qutebrowser/commands/userscripts.py index 67f3d2ec5..e501707bc 100644 --- a/qutebrowser/commands/userscripts.py +++ b/qutebrowser/commands/userscripts.py @@ -282,6 +282,7 @@ class _DummyUserscriptRunner: """ def run(self, _cmd, *_args, _env=None): + """Print an error as userscripts are not supported.""" message.error("Userscripts are not supported on this platform!") diff --git a/qutebrowser/utils/readline.py b/qutebrowser/utils/readline.py index 0f768d1eb..d90d34e80 100644 --- a/qutebrowser/utils/readline.py +++ b/qutebrowser/utils/readline.py @@ -20,7 +20,6 @@ from PyQt5.QtWidgets import QApplication, QLineEdit import qutebrowser.commands.utils as cmd -import qutebrowser.keyinput.modeman as modeman class ReadlineBridge: