From 0bdee1e2920b3a905205b5cf5f4ee4f0cc83f46f Mon Sep 17 00:00:00 2001
From: Florian Bruhin <git@the-compiler.org>
Date: Wed, 7 Feb 2018 18:05:15 +0100
Subject: [PATCH] Stabilize the flaky iframe test

The test above this one loads hello.txt, but we don't wait for the "load
finished" message, so it can arrive after the previous test already finished and
make this test not wait properly.

However, we also can't easily wait for the load finished message in the
previous test as it only appears with QtWebEngine, not QtWebKit.

As a workaround, we simply load another file in that test, to circumvent this
kind of cross-interaction.
---
 tests/end2end/data/hints/iframe_target.html | 1 +
 tests/end2end/features/hints.feature        | 7 +++----
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/tests/end2end/data/hints/iframe_target.html b/tests/end2end/data/hints/iframe_target.html
index db8afad27..bd1e281c2 100644
--- a/tests/end2end/data/hints/iframe_target.html
+++ b/tests/end2end/data/hints/iframe_target.html
@@ -9,6 +9,7 @@
         <iframe id="my-iframe"></iframe>
         <p>
             A <a href="/data/hello.txt" target="my-iframe">link</a> to be opened in the iframe above.
+            A <a href="/data/hello2.txt" target="my-iframe">second link</a> for the iframe.
         </p>
     </body>
 </html>
diff --git a/tests/end2end/features/hints.feature b/tests/end2end/features/hints.feature
index 5da03a085..909eeaf07 100644
--- a/tests/end2end/features/hints.feature
+++ b/tests/end2end/features/hints.feature
@@ -239,12 +239,11 @@ Feature: Using hints
     Scenario: Opening a link with specific target frame in a new tab
         When I open data/hints/iframe_target.html
         And I run :tab-only
-        And I hint with args "links tab" and follow a
-        And I wait until data/hello.txt is loaded
-        And I wait 0.5s
+        And I hint with args "links tab" and follow s
+        And I wait until data/hello2.txt is loaded
         Then the following tabs should be open:
             - data/hints/iframe_target.html
-            - data/hello.txt (active)
+            - data/hello2.txt (active)
 
     Scenario: Clicking on iframe with :hint all current
         When I open data/hints/iframe.html