rnhmjoj/qutebrowser
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Skip remaining tests which are broken on Qt 5.12

Browse Source 
See #4320, #4244
This commit is contained in:
Florian Bruhin 2018-12-11 18:36:52 +01:00
parent 63510c41f5
commit 0953596ed6
2 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
tests/end2end/features/javascript.feature
View File

@ -124,9 +124,9 @@ Feature: Javascript stuff
# https://github.com/qutebrowser/qutebrowser/issues/1190 # https://github.com/qutebrowser/qutebrowser/issues/1190
# https://github.com/qutebrowser/qutebrowser/issues/2495 # https://github.com/qutebrowser/qutebrowser/issues/2495
# Currently broken on Windows: # Currently broken on Windows and on Qt 5.12
# https://github.com/qutebrowser/qutebrowser/issues/4230 # https://github.com/qutebrowser/qutebrowser/issues/4230
@posix @posix @qt<5.12
Scenario: Checking visible/invisible window size Scenario: Checking visible/invisible window size
When I run :tab-only When I run :tab-only
And I open data/javascript/windowsize.html in a new background tab And I open data/javascript/windowsize.html in a new background tab
@ -134,7 +134,7 @@ Feature: Javascript stuff
And I run :tab-next And I run :tab-next
Then the window sizes should be the same Then the window sizes should be the same
@flaky @flaky @qt<5.12
Scenario: Checking visible/invisible window size with vertical tabbar Scenario: Checking visible/invisible window size with vertical tabbar
When I run :tab-only When I run :tab-only
And I set tabs.position to left And I set tabs.position to left

4
tests/unit/javascript/stylesheet/test_stylesheet.py
View File

@ -128,8 +128,8 @@ def test_set_error(stylesheet_tester, config_stub):
stylesheet_tester.check_set(GREEN_BODY_BG) stylesheet_tester.check_set(GREEN_BODY_BG)
@pytest.mark.xfail(qtutils.version_check('5.12', compiled=False), @pytest.mark.skip(qtutils.version_check('5.12', compiled=False),
reason='Broken with Qt 5.12') reason='Broken with Qt 5.12')
def test_appendchild(stylesheet_tester): def test_appendchild(stylesheet_tester):
stylesheet_tester.js.load('stylesheet/simple.html') stylesheet_tester.js.load('stylesheet/simple.html')
stylesheet_tester.init_stylesheet() stylesheet_tester.init_stylesheet()