rnhmjoj/qutebrowser
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

add integration tests for reserved filenames

Browse Source
This commit is contained in:
Daniel Schadt 2017-03-24 11:55:17 +01:00
parent bc4430e5d9
commit 07b3a7db7c
2 changed files with 15 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
qutebrowser/mainwindow/prompt.py
View File

@ -665,6 +665,7 @@ class FilenamePrompt(_BasePrompt):
return path return path
def _show_error(self, msg): def _show_error(self, msg):
log.prompt.error(msg)
QToolTip.showText(self._lineedit.mapToGlobal(QPoint(0, 0)), msg) QToolTip.showText(self._lineedit.mapToGlobal(QPoint(0, 0)), msg)
def accept(self, value=None): def accept(self, value=None):

14
tests/end2end/features/downloads.feature
View File

@ -126,6 +126,20 @@ Feature: Downloading things from a website.
Then the downloaded file ../foo should not exist Then the downloaded file ../foo should not exist
And the downloaded file foo should exist And the downloaded file foo should exist
@windows
Scenario: Downloading a file to a reserved path
When I open data/downloads/download.bin
And I run :prompt-accept COM1
And I run :prompt-cancel
Then "Invalid filename" should be logged
@windows
Scenario: Downloading a file to a drive-relative working directory
When I open data/downloads/download.bin
And I run :prompt-accept C:foobar
And I run :prompt-cancel
Then "Invalid filename" should be logged
## :download-retry ## :download-retry
Scenario: Retrying a failed download Scenario: Retrying a failed download